Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy deprecation warning in 2_hidden_layers_neural_network.py #10424

Merged
merged 10 commits into from
Oct 15, 2023

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

Contributes to #9718 by fixing the numpy deprecation warning in neural_networks/2_hidden_layers_neural_network.py:

neural_network/2_hidden_layers_neural_network.py::neural_network.2_hidden_layers_neural_network.TwoHiddenLayerNeuralNetwork.predict
neural_network/2_hidden_layers_neural_network.py::neural_network.2_hidden_layers_neural_network.example
  /home/runner/work/Python/Python/neural_network/2_hidden_layers_neural_network.py:224: DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)
    return int(self.layer_between_second_hidden_layer_and_output > 0.6)
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@tianyizheng02
Copy link
Contributor Author

This PR successfully fixes the warning:

=============================== warnings summary ===============================
../../../../../opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/dateutil/tz/tz.py:37
  /opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/dateutil/tz/tz.py:37: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    EPOCH = datetime.datetime.utcfromtimestamp(0)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

@tianyizheng02 tianyizheng02 marked this pull request as ready for review October 14, 2023 09:20
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 14, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@cclauss cclauss merged commit b6b45eb into TheAlgorithms:master Oct 15, 2023
3 checks passed
@tianyizheng02 tianyizheng02 deleted the fix-nn-deprecation-warning branch October 15, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants