Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doctests for power_sum.py #10288

Closed
wants to merge 4 commits into from

Conversation

hollowcrust
Copy link
Contributor

@hollowcrust hollowcrust commented Oct 11, 2023

Describe your change:

Contributes to #9718.

I changed the test solve(800, 2) where needed_sum is decreased to 500, as this test has a large search space. The test solve(1000, 10) is not a problem because 2 ** 10 = 1024 and the function terminates quite quickly.

But anyways I feel this test solve(800, 2) is redundant since the last test is solve(400, 2), which is quite similar.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 11, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 11, 2023
@hollowcrust
Copy link
Contributor Author

I also moved the import command because originally the code did not pass ruff check.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 11, 2023
@hollowcrust hollowcrust deleted the patch-speed branch October 17, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant