Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian_elemination - change to remove warning #10221

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

quant12345
Copy link
Contributor

@quant12345 quant12345 commented Oct 10, 2023

Describe your change:

Contributes to #9718.

before: x[row, 0] = (vector[row] - total) / coefficients[row, row]

after: x[row, 0] = (vector[row][0] - total[0]) / coefficients[row, row]

Remove warning:

arithmetic_analysis/gaussian_elimination.py: 10 warnings
 /home/runner/work/Python/Python/arithmetic_analysis/gaussian_elimination.py:37: DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)
x[row, 0] = (vector[row] - total) / coefficients[row, row]
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: " #ISSUE-NUMBER - Speedup our eight slowest pytests (one at a time please) #9718".

… is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 10, 2023
@tianyizheng02
Copy link
Contributor

Can confirm that this resolves the warnings:

================= 1583 passed, 15 warnings in 61.64s (0:01:01) =================
=============================== warnings summary ===============================
../../../../../opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/dateutil/tz/tz.py:37
  /opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/dateutil/tz/tz.py:37: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    EPOCH = datetime.datetime.utcfromtimestamp(0)

machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
  /home/runner/work/Python/Python/machine_learning/k_means_clust.py:236: FutureWarning: The provided callable <function sum at 0x7f241a74f4c0> is currently using SeriesGroupBy.sum. In a future version of pandas, the provided callable will be used directly. To keep current behavior pass the string "sum" instead.
    .agg(

machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
machine_learning/k_means_clust.py::machine_learning.k_means_clust.report_generator
  /home/runner/work/Python/Python/machine_learning/k_means_clust.py:236: FutureWarning: The provided callable <function mean at 0x7f241a7605e0> is currently using SeriesGroupBy.mean. In a future version of pandas, the provided callable will be used directly. To keep current behavior pass the string "mean" instead.
    .agg(

neural_network/2_hidden_layers_neural_network.py::neural_network.2_hidden_layers_neural_network.TwoHiddenLayerNeuralNetwork.predict
neural_network/2_hidden_layers_neural_network.py::neural_network.2_hidden_layers_neural_network.example
  /home/runner/work/Python/Python/neural_network/2_hidden_layers_neural_network.py:224: DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)
    return int(self.layer_between_second_hidden_layer_and_output > 0.6)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

@tianyizheng02 tianyizheng02 merged commit 0b44028 into TheAlgorithms:master Oct 10, 2023
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 10, 2023
@tianyizheng02
Copy link
Contributor

Thanks for the fix!

@quant12345
Copy link
Contributor Author

@tianyizheng02 thank you too.

@quant12345 quant12345 deleted the gaussian branch August 6, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants