Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backtracking -> word_search - replacing the example in doctest #10188

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

quant12345
Copy link
Contributor

@quant12345 quant12345 commented Oct 9, 2023

Describe your change:

Contributes to #9718

I replaced in this pull request 10188, the example in doctest with a less resource-intensive.

Before:

>>> word_exists([["A","A","A","A","A","A"],
...              ["A","A","A","A","A","A"],
...              ["A","A","A","A","A","A"],
...              ["A","A","A","A","A","A"],
...              ["A","A","A","A","A","B"],
...              ["A","A","A","A","B","A"]],
...             "AAAAAAAAAAAAABB")
False

After:

>>> word_exists([["B", "A", "A"], ["A", "A", "A"], ["A", "B", "A"]], "ABB")
False
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: " #ISSUE-9718".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 9, 2023
@quant12345 quant12345 changed the title word_search - replacing the example in doctest backtracking -> word_search - replacing the example in doctest Oct 9, 2023
@tianyizheng02
Copy link
Contributor

  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@quant12345 Please include the issue number in your PR's description. This allows GitHub to automatically link your PR to the original issue. However, don't use the word "fixes", because your PR doesn't completely fix the issue on its own.

@tianyizheng02 tianyizheng02 merged commit 7b996e2 into TheAlgorithms:master Oct 10, 2023
5 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 10, 2023
@quant12345 quant12345 deleted the ws branch August 6, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants