Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both CSV & TSV Profiles does not include images when extracting #94

Closed
IAmVigneswaran opened this issue Apr 24, 2024 · 8 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@IAmVigneswaran
Copy link
Contributor

@orchetect I just realise this issue comes from MarkersExtractor.

For both CSV & TSV export profiles does not include images when extracting the timeline.

"$TOOL_PATH" "$FCPXML_PATH" "$OUTPUT_DIR" --export-format csv --image-format png --result-file-path "$RESULT_JSON" --log-level debug --log "$ERROR_LOG"
@IAmVigneswaran IAmVigneswaran added the bug Something isn't working label Apr 24, 2024
@IAmVigneswaran IAmVigneswaran added this to the 0.3.5 milestone Apr 24, 2024
@orchetect
Copy link
Contributor

orchetect commented Apr 24, 2024

That's not a bug, it's by design. CSV and TSV shouldn't be exporting images. I disabled it when fixing the MIDI file export bug.

@IAmVigneswaran
Copy link
Contributor Author

That's not a bug, it's by design. CSV and TSV shouldn't be exporting images. I disabled it when fixing the MIDI file export bug.

Actually, there should be images for both CSV and TSV. That way, users can import images into their custom workflows, offline database. Not just Notion or Airtable.

@orchetect
Copy link
Contributor

orchetect commented Apr 24, 2024

What if we don't want images and just want the csv/tsv? I don't think we should force image generation for those profiles.

@IAmVigneswaran
Copy link
Contributor Author

What if we don't want images and just want the csv/tsv? I don't think we should force image generation for those profiles.

That is the reason why we have No Media option.

Image Generation should be on by default. It is the key and highlight feature of Marker Data.
If users don't want it, they can enable, No Media option or use Workflow Extension.

@orchetect
Copy link
Contributor

That might not be totally intuitive for new users. I wonder if there is a way to communicate more clearly that No Media means that thumbnail generation will be skipped.

@orchetect orchetect self-assigned this Apr 24, 2024
@IAmVigneswaran
Copy link
Contributor Author

That might not be totally intuitive for new users. I wonder if there is a way to communicate more clearly that No Media means that thumbnail generation will be skipped.

I can rename No Media to Skip Image Generation.

Let's enable Image Generation back for both CSV and TSV in 0.3.5.

@IAmVigneswaran
Copy link
Contributor Author

Done. TheAcharya/MarkerData@a5ee23d

@orchetect
Copy link
Contributor

Done. Will be in 0.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants