For Audio Only .mp4 / .mov the generic audio wave gif is not extracted

[IAmVigneswaran]

I just noticed that with audio only .mp4 / .mov files our generic audio wave .gif is not extracted out. Only the .json and icons are extracted out.

This was possible on our earliest build.

SH Script

$TOOL_PATH "$FCPXML_PATH" "$OUTPUT_DIR" --export-format notion --image-format gif --result-file-path $RESULT_JSON --log-level debug --log $ERROR_LOG

Attached animated gif.
audio-wave.gif.zip

[orchetect]

Do you mean when the generated media file for use with MarkersExtractor has no video track and only has an audio track?

With 0.3.3:

• PNG thumbnails seem to work fine. I ran a test with an audio-only clip. Markers output the placeholder wave image.
• Using GIF thumbnails it's not finding any video frames and fails to create the gif file. This looks to be a bug and should output the placeholder wave animation.

[orchetect]

I may have found the issue. It's correctly using the placeholder animation but it may be trying to request frames that don't exist (ie: at a time corresponding to the original timeline and not offset to the placeholder video's start).

[IAmVigneswaran]

Do you mean when the generated media file for use with MarkersExtractor has no video track and only has an audio track?

Yes. Just Audio in the Primary Storyline. Without any video.

PNG thumbnails seem to work fine.

PNG thumbnails seem to work.

This looks to be a bug and should output the placeholder wave animation.

Only the pre-rendered GIFs are not extracted.

[orchetect]

Further debugging - seems like a thread related issue. The file is actually being written, but the operation never completes so the file remains a hidden temporary file.

AudioOnly.json
.marker-placeholder.gif-ts63
icon-marker.png

[IAmVigneswaran]

Interesting!

[orchetect]

Further narrowing down. Seems to be a regression in the way the image converter handles images that don't exist in a source video.

(We don't actually store a hard-coded gif file of the audio wave in the executable. It's a small 40KB 1-second long .mov file that the executable is converting to a gif file at the respective input dimensions and settings.)

[IAmVigneswaran]

(We don't actually store a hard-coded gif file of the audio wave in the executable. It's a small 40KB 1-second long .mov file that the executable is converting to a gif file at the respective input dimensions and settings.)

I believe this was possible in our earlier much builds before your major refactor of codebase.

Much like our marker Icons, we could store and hardcode the GIF within the code?

[orchetect]

we could store and hardcode the GIF within the code

There's no point, the above explains why our current implementation is preferable. Also, the generated gif file tends to be much smaller than the full-resolution 431KB gif file.

[orchetect]

This should be fixed for next release 0.3.4. Needs some testing to see if typical project conversions still work as expected.

[IAmVigneswaran]

This should be fixed for next release 0.3.4. Needs some testing to see if typical project conversions still work as expected.

Just did a quick test with test-build.

Seems to be working. Thank you!

Will test further with other timelines.

[IAmVigneswaran]

I just tested with a Test Build of Marker Data

For some reason, it is not working.

When building, I assume it is pulling the latest changes from this repo?

[orchetect]

When building [Marker Data], I assume it is pulling the latest changes from this repo?

No, it's taking the latest release.

[IAmVigneswaran]

Noted!