Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Markers on Clip Start and End #56

Closed
IAmVigneswaran opened this issue Nov 4, 2023 · 8 comments
Closed

Allow Markers on Clip Start and End #56

IAmVigneswaran opened this issue Nov 4, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@IAmVigneswaran
Copy link
Contributor

IAmVigneswaran commented Nov 4, 2023

@orchetect There are many FCP users who places Markers on Titles as workaround for "movable" Markers. It is defiantly an effective workaround. They like to place the Markers on the very first frame of the Title.
And they also like to place those tiles underneath the video clip. This provides more flexibility to the users.

marker-on-title

Right now our Tool does not entirely support Markers on Titles specific to this workflow.

2023-11-04 09:49:46 notice: Marker "TD-001" at 00:00:00:17 is out of bounds of its parent clip "TO-DO - Basic Title" (00:00:00:17 - 00:00:02:17) and will be omitted.
2023-11-04 09:49:46 notice: Marker "VFX-001" at 00:00:02:08 is out of bounds of its parent clip "VFX - Basic Title" (00:00:02:08 - 00:00:03:20) and will be omitted.
2023-11-04 09:49:46 notice: Marker "FIX-001" at 00:00:03:11 is out of bounds of its parent clip "FIXING - Basic Title" (00:00:03:11 - 00:00:04:23) and will be omitted.
2023-11-04 09:49:46 notice: Marker "VFX-002" at 00:00:05:03 is out of bounds of its parent clip "VFX - Basic Title" (00:00:05:03 - 00:00:07:20) and will be omitted.
2023-11-04 09:49:46 notice: Marker "FIX-002" at 00:00:08:18 is out of bounds of its parent clip "FIXING - Basic Title" (00:00:08:18 - 00:00:10:05) and will be omitted.
2023-11-04 09:49:46 notice: Marker "TD-002" at 00:00:12:06 is out of bounds of its parent clip "TO-DO - Basic Title" (00:00:12:06 - 00:00:14:06) and will be omitted.
2023-11-04 09:49:46 notice: Marker "FIX-003" at 00:00:16:21 is out of bounds of its parent clip "FIXING - Basic Title" (00:00:16:21 - 00:00:23:01) and will be omitted.
2023-11-04 09:49:46 notice: Marker "VFX-003" at 00:00:23:22 is out of bounds of its parent clip "VFX - Basic Title" (00:00:23:22 - 00:00:25:09) and will be omitted.
2023-11-04 09:49:46 notice: Marker "VFX-004" at 00:00:26:15 is out of bounds of its parent clip "VFX - Basic Title" (00:00:26:15 - 00:00:29:21) and will be omitted.
2023-11-04 09:49:46 notice: Marker "VFX-005" at 00:00:33:23 is out of bounds of its parent clip "VFX - Basic Title" (00:00:33:23 - 00:00:37:04) and will be omitted.
2023-11-04 09:49:46 notice: Marker "TD-003" at 00:00:35:16 is out of bounds of its parent clip "TO-DO - Basic Title" (00:00:35:16 - 00:00:37:16) and will be omitted.
2023-11-04 09:49:46 notice: Marker "FIX-004" at 00:00:44:01 is out of bounds of its parent clip "FIXING - Basic Title" (00:00:44:01 - 00:00:50:06) and will be omitted.
2023-11-04 09:49:46 notice: Marker "TD-004" at 00:00:58:17 is out of bounds of its parent clip "TO-DO - Basic Title" (00:00:58:17 - 00:01:00:17) and will be omitted.
2023-11-04 09:49:46 notice: Marker "FIX-005" at 00:01:02:08 is out of bounds of its parent clip "FIXING - Basic Title" (00:01:02:08 - 00:01:08:13) and will be omitted.
2023-11-04 09:49:46 notice: Marker "TD-005" at 00:01:13:04 is out of bounds of its parent clip "TO-DO - Basic Title" (00:01:13:04 - 00:01:15:04) and will be omitted.
2023-11-04 09:49:46 notice: Marker "TD-006" at 00:01:24:23 is out of bounds of its parent clip "TO-DO - Basic Title" (00:01:24:23 - 00:01:26:23) and will be omitted.

We should include and support this workflow. Can we have a switch for is? For example --markers-on-titles.

When enable, our tool would basically take the TIMECODE position from the Marker and apply it on the Video file for image extraction. It would still extract all the metadata as per usual for the CSV or JSON.

Sample - FCPXML
Markers on Titles.fcpxmld.zip

@IAmVigneswaran IAmVigneswaran added the enhancement New feature or request label Nov 4, 2023
@orchetect
Copy link
Contributor

It looks like it's just excluding markers that are exactly on a clip boundary right now. It would probably be easy just to include them always. I don't see why we would need a separate flag for it.

@IAmVigneswaran
Copy link
Contributor Author

To differentiate "Markers on Titles (Movable Markers)" with "Normal Markers on Graphic Titles", user must add a special character on the Marker.

For example: [!] at the start of the Marker Field.

special-character

That way MarkersExtractor can identify and differentiate between the two.

@IAmVigneswaran
Copy link
Contributor Author

It looks like it's just excluding markers that are exactly on a clip boundary right now. It would probably be easy just to include them always. I don't see why we would need a separate flag for it.

It would be great if no separate flag is needed.

Thank you.

@IAmVigneswaran
Copy link
Contributor Author

It looks like it's just excluding markers that are exactly on a clip boundary right now. It would probably be easy just to include them always. I don't see why we would need a separate flag for it.

I believe there is a small difference?

Yes, enabling --include-outside-clip-boundariesdoes work with the above sample FCPXML.

But, it would also include other markers when the user has specifically Trimmed the clips

Marker_boundaries

@orchetect
Copy link
Contributor

enabling --include-outside-clip-boundaries

I'm not talking about that. I mean under normal use we should just allow markers on a clip start or end.

@IAmVigneswaran
Copy link
Contributor Author

enabling --include-outside-clip-boundaries

I'm not talking about that. I mean under normal use we should just allow markers on a clip start or end.

Oh Yes. Noted. We should allow markers on a clip start or end by default.

@IAmVigneswaran IAmVigneswaran changed the title Using Markers on Titles (As workaround for Movable Markers) Allow Markers on Clip Start and End Nov 4, 2023
@IAmVigneswaran IAmVigneswaran added this to the 0.2.4 milestone Nov 11, 2023
@orchetect
Copy link
Contributor

This is implemented and will be in next release (0.2.4).

@orchetect orchetect self-assigned this Nov 16, 2023
@IAmVigneswaran
Copy link
Contributor Author

Just tested this on latest 0.2.4 build. It works now!

I will close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants