Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Memory4gb, updated deprecated emscripten arguments, updated package.json dependencies #57

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

vegarringdal
Copy link
Contributor

  • update package.json dependencies
  • update emscripten commands
  • added -s MAXIMUM_MEMORY=4GB
    • Now my biggest IFC loads when I try it with npm run dev :-)
  • updated deprecated arguments

More info about deprecated arguments
em++: warning: please replace -g4 with -gsource-map [-Wdeprecated]
em++: warning: EXTRA_EXPORTED_RUNTIME_METHODS is deprecated, please use EXPORTED_RUNTIME_METHODS instead [-Wdeprecated]

@vegarringdal
Copy link
Contributor Author

Noticed one of my commits had a typo on commands, woops :-)
Should have been arguments, but guess you squash it anyways if you want it.

@vegarringdal
Copy link
Contributor Author

Sample here uses custom built wasm file with the PR enabled

https://vegarringdal.github.io/web-ifc-experiment/

@agviegas you had some large files failing too, you can maybe try em here.

@agviegas
Copy link
Collaborator

Indeed, this works! Very nice work @vegarringdal!
image

@vegarringdal
Copy link
Contributor Author

@agviegas
That model looks nice
HVAC for a large building from the looks of it

Public model ?

@vegarringdal
Copy link
Contributor Author

@agviegas
If you have multiple files for that building, you can select all files on the file open in that sample, and it will load all

@agviegas
Copy link
Collaborator

Unfortunately it's not a public model, but it confirms that this work. Very cool!

@tomvandig tomvandig merged commit 5376065 into ThatOpen:main Jul 5, 2021
@tomvandig
Copy link
Collaborator

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants