Az/wi2021 pages new nav

[zaudtke]

Description

All pages now use default layout, which has be changed to be what Rootlayout was. All pages use the new new header.
Went through site, and fixed all found issues with pages using new Header. Mostly too much or not enough space between header and rest of page.

Fixed a couple of obviously broken links from WI2021 Home page.

NOTE: Links in Call for Counselors/Voting is busted, but not open yet. Thought is to fix with work on dynamic pages and better routing.

Note: Markdown pages (both blog and policies) have hard coded links to pages in WI without an event. Will look to address with dynamice data/routing story.

Fixes #629 #631

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Self Browser testing crawling the site looking for inconsistencies and/links to WI or WI/2020

Checklist:

• [NA] I have updated the documentation if necessary
• [NA] I have updated the stories as necessary
• [NA] I have updated the specs necessary

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/that-conference/that-website/3VfAU2KSSMrhC5wYCxPBiSnPSKfJ
✅ Preview: https://that-website-git-az-wi2021-pages-new-nav-that-conference.vercel.app

[brettski]

Wow that menu is in-your-face!
It's pretty big text size, but it works

The resources section is directly tied to the focused event. Even on the root page the focused event appears to be WI 2021, and those resources are all referred to under wi/2021. Does it make sense to clarify that so those resources seem more part of WI 2021?

[theClarkSell]

📝Changed routes:

/blog/[post]	/
(view full size)	(view full size)

…ssion-edit/[sessionId]	…on-preview/[sessionId]
(view full size)	(view full size)

/tx/2021	/wi/2020
(view full size)	(view full size)

And 1 other route:

• /wi

Commit 2dbdbb8 (https://that-website-nh3utjo9k-that-conference.vercel.app).

[zaudtke]

@brettski yeah, you don't need glasses :)

With regards to links, nav, 2021 etc.... I left them hardcoded for now. My next plan of attack involves a bit of everything involving routing and dynamic stuff based on Slug. I wanted to get this out there first, so if needed, call for counselors could take precedence over dynamics if necessary. Also, Call for Counselors and Voting is jacked, as all links still have them at wi/.

I think some of those pages will need to eventually be revisited/revised/removed and replaced with more generic ones where necessary, and event specific where needed. A lot of the verbiage is WI specific.

1. Make WI/2021 dynamic based on slug (or most of it)
2. Make Header/Footer Slug aware to hide/show/change target links. ie, if in WI2021 top left menu shows, and footer links are appropriate. If at root, either hide, or go to generic pages that say which event are you looking for?
3. clean up routing in general for all the pages, so that it makes sense.
4. Update links throughout to handle above changes.

FYI, just pushed a change to fix #631

[brettski]

@brettski yeah, you don't need glasses :)

With regards to links, nav, 2021 etc.... I left them hardcoded for now. My next plan of attack involves a bit of everything involving routing and dynamic stuff based on Slug. I wanted to get this out there first, so if needed, call for counselors could take precedence over dynamics if necessary. Also, Call for Counselors and Voting is jacked, as all links still have them at wi/.

I think some of those pages will need to eventually be revisited/revised/removed and replaced with more generic ones where necessary, and event specific where needed. A lot of the verbiage is WI specific.

1. Make WI/2021 dynamic based on slug (or most of it)
2. Make Header/Footer Slug aware to hide/show/change target links. ie, if in WI2021 top left menu shows, and footer links are appropriate. If at root, either hide, or go to generic pages that say which event are you looking for?
3. clean up routing in general for all the pages, so that it makes sense.
4. Update links throughout to handle above changes.

FYI, just pushed a change to fix #631

Perhaps I am a bit premature on those items and it seems you know of them and will tackle them in the future.

1. okay
2. eventually this sounds good. It also seems there is much to correct to get there.
3. .
4. .

[zaudtke]

Agreed. I'm trying to get bang for buck, without having super huge PR's (time and size)