IEntityFactory: createCollection() returns iterable<Entity>

Tharos · Apr 8, 2024 · 58c3513 · 58c3513
1 parent 09f98c0
commit 58c3513
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 19 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -50,16 +50,6 @@ parameters:
 			count: 2
 			path: src/LeanMapper/Entity.php
 
-		-
-			message: "#^Method LeanMapper\\\\Entity\\:\\:getBelongsToManyValue\\(\\) should return array\\<LeanMapper\\\\Entity\\> but returns mixed\\.$#"
-			count: 1
-			path: src/LeanMapper/Entity.php
-
-		-
-			message: "#^Method LeanMapper\\\\Entity\\:\\:getHasManyValue\\(\\) should return array\\<LeanMapper\\\\Entity\\> but returns mixed\\.$#"
-			count: 1
-			path: src/LeanMapper/Entity.php
-
 		-
 			message: "#^Parameter \\#1 \\$entityFactory of method LeanMapper\\\\Entity\\:\\:setEntityFactory\\(\\) expects LeanMapper\\\\IEntityFactory, LeanMapper\\\\IEntityFactory\\|null given\\.$#"
 			count: 1
@@ -240,11 +230,6 @@ parameters:
 			count: 1
 			path: src/LeanMapper/Reflection/PropertyValuesEnum.php
 
-		-
-			message: "#^Method LeanMapper\\\\Repository\\:\\:createEntities\\(\\) should return array\\<LeanMapper\\\\Entity\\> but returns mixed\\.$#"
-			count: 1
-			path: src/LeanMapper/Repository.php
-
 		-
 			message: "#^Parameter \\#1 \\$id of method LeanMapper\\\\Entity\\:\\:attach\\(\\) expects int\\|string, mixed given\\.$#"
 			count: 1

diff --git a/src/LeanMapper/Entity.php b/src/LeanMapper/Entity.php
@@ -880,7 +880,7 @@ private function getHasOneValue(Property $property, Relationship\HasOne $relatio
 
 
     /**
-     * @return Entity[]
+     * @return iterable<Entity>
      * @throws InvalidValueException
      */
     private function getHasManyValue(
@@ -951,7 +951,7 @@ private function getBelongsToOneValue(Property $property, Relationship\BelongsTo
 
 
     /**
-     * @return Entity[]
+     * @return iterable<Entity>
      */
     private function getBelongsToManyValue(Property $property, Relationship\BelongsToMany $relationship, ?Filtering $filtering = null)
     {

diff --git a/src/LeanMapper/IEntityFactory.php b/src/LeanMapper/IEntityFactory.php
@@ -35,7 +35,7 @@ function createEntity(string $entityClass, $arg = null): Entity;
      * Allows wrap set of entities in custom collection
      *
      * @param Entity[] $entities
-     * @return mixed
+     * @return iterable<Entity>
      */
     function createCollection(array $entities);
 

diff --git a/src/LeanMapper/Repository.php b/src/LeanMapper/Repository.php
@@ -320,7 +320,7 @@ protected function createEntity(DibiRow $dibiRow, ?string $entityClass = null, ?
      * Creates new set of Entity's instances from given array of \Dibi\Row instances
      *
      * @param \Dibi\Row[] $rows
-     * @return Entity[]
+     * @return iterable<Entity>
      */
     protected function createEntities(array $rows, ?string $entityClass = null, ?string $table = null)
     {