fix default value of ensure_ascii to match comments #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL /cc @willmcgugan |
willmcgugan
reviewed
Sep 23, 2022
CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Fix NO_COLOR support on legacy Windows https://github.com/Textualize/rich/pull/2458 | |||
| - Fix pretty printer handling of cyclic references https://github.com/Textualize/rich/pull/2524 | |||
| - Fix missing `mode` property on file wrapper breaking uploads via `requests` https://github.com/Textualize/rich/pull/2495 | |||
| - Fix mismatching default value of prarmeter `ensure_ascii` https://github.com/Textualize/rich/pull/2538 | |||
willmcgugan
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Make the behaviour of
ensure_asciiparameter match the comments and the documents.The default value of
ensure_asciiis supposed to be False, but it is True in the master branch, according to the comments or the documents, like:rich/rich/__init__.py
Line 84 in bfea226
and
rich/rich/__init__.py
Line 98 in bfea226
I am not sure of the original preference, but I think the escaping result may be confusing since it looks like an additional unexpected process.
Thus I change the default value to False.