-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporting console content to SVG #2101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2101 +/- ##
==========================================
- Coverage 99.48% 99.47% -0.01%
==========================================
Files 72 72
Lines 7334 7412 +78
==========================================
+ Hits 7296 7373 +77
- Misses 38 39 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic.
Could we move the styles from inline in to the <style> tag. You may be able to reuse the code from export_html.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Would you mind updating the SVG in the docs to use the stylesheet.
Feel free to merge once that's done.
Type of changes
Checklist
Description
Adds ability to export SVGs from Rich containing console contents.