Skip to content

Conversation

@ojemuyiwa
Copy link

useing webpack analyser all @mui import sizes should be reduced

@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for any-viewer failed.

Name Link
🔨 Latest commit 34a5e54
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/63f519dd3f42090008c7112b

@ojemuyiwa ojemuyiwa closed this Feb 21, 2023
@ojemuyiwa
Copy link
Author

Sorry this is supposed to be for forked repo, i'm trying to reduce the material import sizes

@pionxzh
Copy link
Collaborator

pionxzh commented Feb 22, 2023

#169 should have already fixed the problem?

@ojemuyiwa
Copy link
Author

#169 should have already fixed the problem?

Nope huge build with multiple modules included.

Reduced changes in my forked repo in pink, this in violet.
Screenshot 2023-02-22 at 13 14 04
Screenshot 2023-02-22 at 13 19 14

Basically just did Ctrl + Find for @mui/material and replaced as suggested here minimizing bundle size

@pionxzh
Copy link
Collaborator

pionxzh commented Feb 22, 2023

Interesting. I see. I will verify the bundling size again recently.

@pionxzh
Copy link
Collaborator

pionxzh commented Feb 23, 2023

Yo @ojemuyiwa bro... I realized that I never released #169, which should be why you still get a huge build. Not sure if you are willing to test again with v2.14.0?

@ojemuyiwa
Copy link
Author

Yo @ojemuyiwa bro... I realized that I never released #169, which should be why you still get a huge build. Not sure if you are willing to test again with v2.14.0?

For sure, I'll pull and test tomorrow morning and give you feedback. If you want the optimised code I can branch and fix for you here as well.

Thanks and much appreciated 👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants