Exporting as ESM and CJS

[anthonyalayo]

1. don't bundle modules, that allows for more effective tree shaking
2. remove the browser export, it seems unnecessary in 2023
3. keep exporting cjs as a single file
4. move emotion into peer dependencies, which is recommended by the project

This presently does not build, but it's almost there. I'll need a bit of help @pionxzh @rtritto

[netlify]

✅ Deploy Preview for any-viewer ready!

Name	Link
🔨 Latest commit	bf5a86e
🔍 Latest deploy log	https://app.netlify.com/sites/any-viewer/deploys/64169e3669a81b00088b59fc
😎 Deploy Preview	https://deploy-preview-181--any-viewer.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[rtritto]

Should we convert this project to ESM insead of convert it for export?
ESM Guide: Pure ESM package

4. move emotion into peer dependencies, which is recommended by the project

I think it's better to split this in a separated PR

[pionxzh]

Should we convert this project to ESM insead of convert it for export? ESM Guide: Pure ESM package

4. move emotion into peer dependencies, which is recommended by the project

I think it's better to split this in a separated PR

yes, let's move it to another one.

[pionxzh]

Let me check what's wrong. 👌 Sorry I was so busy.

[pionxzh]

should we just use cjs instead?

[pionxzh]

About 2, I need to think and ask more about why they were provided at first.

[pionxzh]

Can you move these 2 to another PR so we can merge that first?

• Delete tsconfig.node.json
• Remove @types/web

And this can be another

"sideEffects": false

So this PR will focus on the changes of the bundling process and dropping the browser file (which I still can't decide yet.)

[rtritto]

Needed these changes #181 (comment) too

[pionxzh]

Needed these changes #181 (comment) too

Not sure if it is just me or what. I couldn't see the content of your comment 😵‍💫

[rtritto]

Just check the review comments

[pionxzh]

@anthonyalayo Sorry that we did a rebasing to remove some sensitive content from the history. I just rebased this PR to fix the history.

I think we can close this first as most of the content has been split to other PRs. And we don't have a plan to drop the browser build. Is that ok?

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (f5411a2) 87.63% compared to head (bf5a86e) 87.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   87.63%   87.65%   +0.01%     
==========================================
  Files          18       18              
  Lines        1982     1984       +2     
  Branches      358      358              
==========================================
+ Hits         1737     1739       +2     
  Misses        245      245              

Impacted Files	Coverage Δ
src/stores/JsonViewerStore.ts	92.24% <100.00%> (+0.06%)	⬆️
src/stores/typeRegistry.tsx	94.75% <100.00%> (+0.01%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[anthonyalayo]

Sounds good!