-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GUI and deployment scripts use compiling service #2848
Open
bobbai00
wants to merge
22
commits into
master
Choose a base branch
from
jiadong-use-compiling-service
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
changed the title
Make GUI use compiling service
Make GUI and deployment scripts use compiling service
Sep 20, 2024
…ompilation related components
bobbai00
force-pushed
the
jiadong-use-compiling-service
branch
from
October 1, 2024 13:36
557a9aa
to
e7f6b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the GUI, backend, and shell scripts under
core/scripts
to incorporate with theTexeraWorkflowCompilingService
introduced in #2796How to test this PR
To test with the user-sys enabled, set the
user-sys.jwt.256-bit-secret
to be a 256-bit string inapplication.conf
.For backend, launch 3 services
For frontend, launch the GUI normally.
Core changes
1. GUI
WorkflowCompilingService
is addedWorkflow Compiling Service provides mainly 3 functionalities:
EditingTimeCompilationRequest
and saving in the ExecutionStateInfo)/core/gui/src/app/common/type/proto
protoc-generated ts files are addedThese files are generated and added based on proto files in
/core/amber/src/main/protobuf
. The main purpose is to correctly de-serialize thePhysicalPlan
given by theWorkflowCompilingService
This service will talk to the
TexeraWorkflowCompilingService
in a certain debounce time when:SchemaPropagationService
is removed.Schema propagation feature now relies on the
WorkflowCompilingService
's endpoint to accomplishEditingTimeCompilationRequest
andOperatorReuseCacheStatusService
are removedThe main purpose of
EditingTimeCompilationRequest
andOperatorReuseCacheStatusService
is to report the static errors Now this relies on theWorkflowCompilingService
to accomplish.2. Backend
Some bugs in
WorkflowCompilationResource
are fixedThese bugs are found when frontend is actually using it. This PR fixes those issues.
EditingTimeCompilationRequest
and its handler are removedNow the compilation is done by
TexeraWorkflowCompilingService
.SchemaPropagationResource
is removedNow the schema propagation is done by the
TexeraWorkflowCompilingService
.3. scripts
workflow-compiling-service.sh
is addedThis script is mainly used to launch the
TexeraWorkflowCompilingService
.Related build and deploy shell scripts are updated
These scripts are updated to include the launching and terminating of
TexeraWorkflowCompilingService