Skip to content

Conversation

@18chanp1
Copy link
Contributor

@18chanp1 18chanp1 commented Oct 3, 2025

Added new pull request opened to hadoop on line 1943:
apache/hadoop#8010

https://github.com/apache/hadoop,cc2babc1f75c93bf89a8f10da525f944c15d02ea,hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient,org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacement,ID,,,
https://github.com/apache/hadoop,cc2babc1f75c93bf89a8f10da525f944c15d02ea,hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient,org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacementForCompressedFiles,ID,,,
https://github.com/apache/hadoop,cc2babc1f75c93bf89a8f10da525f944c15d02ea,hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient,org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacement,ID,Opened,https://github.com/apache/hadoop/pull/8010,
https://github.com/apache/hadoop,cc2babc1f75c93bf89a8f10da525f944c15d02ea,hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient,org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacementForCompressedFiles,ID,DeveloperFixed,,could not reproduce: https://github.com/apache/hadoop/commit/551615fa13f65ae996bae9c1bacff189539b6557
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot claim DeveloperFixed unless you can find where it was fixed. Did you check that the test was ID in the commit where it was reported (cc2babc1f75c93bf89a8f10da525f944c15d02ea)? Did you run the entire test class (or even the entire module) in the latest commit?

@darko-marinov
Copy link
Contributor

You may want to split Opened (which I can easily accept) and DeveloperFixed (which will require more inspection).

Please do not add links to the real PRs in the PR description here. I can see those links in pr-data.csv.

@18chanp1
Copy link
Contributor Author

18chanp1 commented Oct 22, 2025

This was split into #1654 (work in progress) and #1653 (merged), so I want to close this as duplicate

@darko-marinov
Copy link
Contributor

Okay, I can close this now, but in the future don't split one PR into two new; rather, open one new and then update one existing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants