refactor: anchor assembly-prefix exclusion at name boundaries#972
Merged
Conversation
|
Contributor
Test Results 23 files - 27 23 suites - 27 7m 43s ⏱️ -18s Results for commit c149539. ± Comparison against base commit e3547a2. This pull request removes 3189 and adds 3171 tests. Note that renamed tests count towards both. |
`ExcludedAssemblyPrefixes` were matched as raw substrings against `Assembly.FullName` with a culture-sensitive `StartsWith`, so e.g. `System` also excluded an unrelated assembly named `Systemics`, letting a first-party assembly be silently skipped during scanning. Match against the simple assembly name (`GetName().Name`) using an ordinal, name-segment-boundary comparison (`name == prefix || name.StartsWith(prefix + .)`). Single-name entries like `netstandard` and `DynamicProxyGenAssembly2` still match via the equality arm. Assemblies without a name are no longer scanned.
c149539 to
3f53798
Compare
Contributor
🚀 Benchmark ResultsDetails
|
Contributor
👽 Mutation ResultsaweXpectDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0aweXpect.CoreDetails
The final mutation score is 77.27%Coverage Thresholds: high:80 low:60 break:0 |
github-actions Bot
added a commit
that referenced
this pull request
May 31, 2026
…ion at name boundaries (#972) by Valentin Breuß
github-actions Bot
added a commit
that referenced
this pull request
May 31, 2026
…ion at name boundaries (#972) by Valentin Breuß
Contributor
|
This is addressed in release v2.35.0. |
This was referenced Jun 8, 2026
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



ExcludedAssemblyPrefixeswere matched as raw substrings againstAssembly.FullNamewith a culture-sensitiveStartsWith, so e.g.Systemalso excluded an unrelated assembly namedSystemics, letting a first-party assembly be silently skipped during scanning.Match against the simple assembly name (
GetName().Name) using an ordinal, name-segment-boundary comparison (name == prefix || name.StartsWith(prefix + .)). Single-name entries likenetstandardandDynamicProxyGenAssembly2still match via the equality arm. Assemblies without a name are no longer scanned.