Skip to content

coverage: ensure that NaN is considered equal to NaN#811

Merged
vbreuss merged 1 commit intomainfrom
topic/ensure-nan-isequalto-nan
Oct 17, 2025
Merged

coverage: ensure that NaN is considered equal to NaN#811
vbreuss merged 1 commit intomainfrom
topic/ensure-nan-isequalto-nan

Conversation

@vbreuss
Copy link
Copy Markdown
Member

@vbreuss vbreuss commented Oct 17, 2025

No description provided.

@vbreuss vbreuss self-assigned this Oct 17, 2025
Copilot AI review requested due to automatic review settings October 17, 2025 15:16
@vbreuss vbreuss added the coverage Additional tests for edge cases or improvement of test coverage label Oct 17, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test coverage to ensure that NaN (Not a Number) values are correctly handled in the IsEqualTo().Within() assertion chain for floating-point numbers. The change addresses the mathematical edge case where NaN should be considered equal to itself when using tolerance-based comparisons.

  • Adds comprehensive test coverage for NaN equality scenarios across all supported floating-point numeric types
  • Tests both nullable and non-nullable variants of double and float types
  • Validates that NaN == NaN evaluates to true within the assertion framework's tolerance-based comparison logic

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

    10 files  ± 0      10 suites  ±0   4m 15s ⏱️ -19s
16 758 tests  -  1  16 757 ✅  -  1  1 💤 ±0  0 ❌ ±0 
47 028 runs  +12  47 027 ✅ +12  1 💤 ±0  0 ❌ ±0 

Results for commit 30eb0fb. ± Comparison against base commit 0b4a83e.

@vbreuss vbreuss merged commit 56588c7 into main Oct 17, 2025
14 checks passed
@vbreuss vbreuss deleted the topic/ensure-nan-isequalto-nan branch October 17, 2025 18:18
@github-actions
Copy link
Copy Markdown
Contributor

This is addressed in release v2.27.0.

@github-actions github-actions Bot added the state: released The issue is released label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coverage Additional tests for edge cases or improvement of test coverage state: released The issue is released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants