Conversation
- `Is{Not}Absolute`
- `Is{Not}File`
- `Is{Not}Loopback`
- `Is{Not}Unc`
- `HasDefaultPort` / `DoesNotHaveDefaultPort`
There was a problem hiding this comment.
Pull Request Overview
This PR introduces expectations for Uri objects in the aweXpect assertion library, adding fluent API methods for validating common Uri properties and characteristics.
Key changes:
- Added Uri-specific assertion methods for absolute, file, loopback, and UNC path validation
- Added port validation methods for checking default port usage
- Enhanced source generator to support more flexible naming patterns
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/aweXpect.Tests/aweXpect.Tests.csproj.DotSettings | Added namespace folder skip for uris test directory |
| Tests/aweXpect.Tests/Uris/*.cs | Created comprehensive test suites for all new Uri assertion methods |
| Source/aweXpect/aweXpect.csproj.DotSettings | Added namespace folder skip for uris source directory |
| Source/aweXpect/That/Uris/*.cs | Implemented Uri assertion methods using source generator attributes |
| Source/aweXpect.SourceGenerators/*.cs | Enhanced source generator to support custom positive/negative method names and expectation texts |
| Tests/aweXpect.Api.Tests/Expected/*.txt | Updated API surface tests to include new ThatUri class |
| Source/aweXpect/That/Chars/ThatNullableChar.*.cs | Fixed nullable char assertion implementations |
vbreuss
force-pushed
the
topic/add-uri-expectations
branch
from
ab1655b to
ba40319
Compare
|
Contributor
🚀 Benchmark ResultsDetails
|
Contributor
👽 Mutation ResultsaweXpectDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0aweXpect.CoreDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0 |
Contributor
Test Results 14 files - 1 14 suites - 1 4m 7s ⏱️ +51s Results for commit ba40319. ± Comparison against base commit f68f8a1. This pull request removes 1048 and adds 1607 tests. Note that renamed tests count towards both. |
This was referenced Sep 14, 2025
Contributor
|
This is addressed in release v2.24.0. |
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces expectations for Uri objects in the aweXpect assertion library, adding fluent API methods for validating common Uri properties and characteristics.
Key changes:
ThatUri.Is{Not}Absolute()ThatUri.Is{Not}File()ThatUri.Is{Not}Loopback()ThatUri.Is{Not}Unc()ThatUri.HasDefaultPort()/ThatUri.DoesNotHaveDefaultPort()