Skip to content

fix: download large benchmarks file#779

Merged
vbreuss merged 2 commits intomainfrom
topic/build-benchmarks
Sep 13, 2025
Merged

fix: download large benchmarks file#779
vbreuss merged 2 commits intomainfrom
topic/build-benchmarks

Conversation

@vbreuss
Copy link
Copy Markdown
Member

@vbreuss vbreuss commented Sep 13, 2025

This PR fixes an issue with downloading large benchmark files by switching from GitHub's Contents API to direct raw file downloads. The GitHub Contents API has size limitations that were preventing proper retrieval of large benchmark files.

@vbreuss vbreuss self-assigned this Sep 13, 2025
Copilot AI review requested due to automatic review settings September 13, 2025 19:24
@vbreuss vbreuss added the bug Something isn't working label Sep 13, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with downloading large benchmark files by switching from GitHub's Contents API to direct raw file downloads. The GitHub Contents API has size limitations that were preventing proper retrieval of large benchmark files.

Comment thread Pipeline/Build.Benchmarks.cs
Comment thread Pipeline/Build.Benchmarks.cs Outdated
@vbreuss vbreuss merged commit 861e39d into main Sep 13, 2025
9 checks passed
@vbreuss vbreuss deleted the topic/build-benchmarks branch September 13, 2025 19:27
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 13, 2025

🚀 Benchmark Results

Details

BenchmarkDotNet v0.14.0, Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.414
[Host] : .NET 8.0.20 (8.0.2025.41914), X64 RyuJIT AVX2

Job=InProcess Toolchain=InProcessEmitToolchain IterationCount=15
LaunchCount=1 WarmupCount=10

Method Mean Error StdDev Gen0 Gen1 Allocated
Bool_aweXpect 231.0 ns 2.41 ns 2.14 ns 0.0300 - 504 B
Bool_FluentAssertions 249.1 ns 2.61 ns 2.44 ns 0.0567 - 952 B
Bool_TUnit 908.2 ns 9.13 ns 8.54 ns 0.1431 - 2408 B
Equivalency_aweXpect 303,345.5 ns 1,445.02 ns 1,351.67 ns 20.0195 0.9766 335556 B
Equivalency_FluentAssertions 2,199,471.1 ns 23,787.58 ns 21,087.07 ns 273.4375 46.8750 4584416 B
Equivalency_TUnit 704,995.8 ns 4,103.62 ns 3,637.75 ns 51.7578 2.9297 880545 B
Int_GreaterThan_aweXpect 254.7 ns 1.77 ns 1.57 ns 0.0486 - 816 B
Int_GreaterThan_FluentAssertions 252.9 ns 3.95 ns 3.70 ns 0.0730 - 1224 B
Int_GreaterThan_TUnit 1,235.7 ns 11.62 ns 10.87 ns 0.1774 - 2984 B
ItemsCount_AtLeast_aweXpect 507.3 ns 4.81 ns 4.27 ns 0.0868 - 1464 B
ItemsCount_AtLeast_FluentAssertions 505.8 ns 7.40 ns 6.93 ns 0.1192 - 2008 B
ItemsCount_AtLeast_TUnit 17,304.4 ns 137.38 ns 128.51 ns 1.6174 - 27480 B
String_aweXpect 435.4 ns 4.10 ns 3.83 ns 0.0734 - 1232 B
String_FluentAssertions 484.0 ns 6.33 ns 5.61 ns 0.1287 - 2168 B
String_TUnit 1,260.0 ns 11.32 ns 10.59 ns 0.1831 - 3072 B
StringArray_aweXpect 1,817.7 ns 6.65 ns 5.89 ns 0.1717 - 2888 B
StringArray_FluentAssertions 1,308.9 ns 9.23 ns 8.18 ns 0.2480 - 4152 B
StringArray_TUnit 3,340.1 ns 21.52 ns 19.07 ns 0.3128 - 5296 B
StringArrayInAnyOrder_aweXpect 2,176.6 ns 18.66 ns 16.54 ns 0.1831 - 3080 B
StringArrayInAnyOrder_FluentAssertions 151,923.1 ns 563.70 ns 527.28 ns 3.4180 - 63787 B
StringArrayInAnyOrder_TUnit 4,047.9 ns 39.23 ns 36.70 ns 0.3815 - 6488 B

@github-actions
Copy link
Copy Markdown
Contributor

👽 Mutation Results

Mutation testing badge

aweXpect

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

aweXpect.Core

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

github-actions Bot added a commit that referenced this pull request Sep 13, 2025
github-actions Bot added a commit that referenced this pull request Sep 13, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This is addressed in release v2.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working state: released The issue is released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants