Skip to content

refactor: re-enable skipped test#756

Merged
vbreuss merged 1 commit intomainfrom
topic/re-enable-skipped-test
Sep 4, 2025
Merged

refactor: re-enable skipped test#756
vbreuss merged 1 commit intomainfrom
topic/re-enable-skipped-test

Conversation

@vbreuss
Copy link
Copy Markdown
Member

@vbreuss vbreuss commented Sep 4, 2025

This PR re-enables a previously skipped unit test by removing the Skip parameter from the [Fact] attribute. The test was temporarily disabled with a TODO comment indicating it should be re-enabled after a core update.

  • Removes the Skip parameter from a test method to make it executable again

@vbreuss vbreuss self-assigned this Sep 4, 2025
Copilot AI review requested due to automatic review settings September 4, 2025 04:34
@vbreuss vbreuss added the coverage Additional tests for edge cases or improvement of test coverage label Sep 4, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables a previously skipped unit test by removing the Skip parameter from the [Fact] attribute. The test was temporarily disabled with a TODO comment indicating it should be re-enabled after a core update.

  • Removes the Skip parameter from a test method to make it executable again

@vbreuss vbreuss enabled auto-merge (squash) September 4, 2025 04:34
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 4, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

Test Results

    14 files   - 24      14 suites   - 24   4m 16s ⏱️ -32s
17 350 tests  - 26  17 348 ✅  - 25  2 💤  - 1  0 ❌ ±0 
48 711 runs   - 72  48 709 ✅  - 69  2 💤  - 3  0 ❌ ±0 

Results for commit c6ce4ed. ± Comparison against base commit 898ff97.

This pull request removes 1570 and adds 1544 tests. Note that renamed tests count towards both.
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message89a379a2-9814-4a3a-9d43-c8fa89958e77")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "messagebd25f5cb-7242-449c-90e6-da9ce79a4a52")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "messagef2107c57-865d-468e-bf48-79b34e884b7a")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message2dde0b24-75ca-4bc6-a710-52764bbc010f")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message5680cf6c-71c5-4799-97ab-657f8dc1c508")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message8f84f7a9-c31f-47d2-a304-1f7952cf6a84")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason2106230d-852d-4a59-9e1a-33907fa3c365")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason927695d9-8871-436b-8a4c-736aef5ef757")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reasonf29c148b-3ade-4479-b9fe-7d2a4fc971c2")
aweXpect.Core.Tests.FailTests ‑ Unless_ShouldThrowException(condition: False, reason: "reason550f4df1-e725-490b-90e0-bd07dc406974")
…
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message0ba5e187-7cd4-440f-a526-4a20b48ff9eb")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message0c9aaf49-0843-440e-86bf-07f3eb3f031d")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "messagecab72467-6b40-4726-a1ca-5b6412f279ff")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message0eb23aae-42bf-472a-bfe0-ed77fac07b4a")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message2f4d878a-0ac8-49bf-bcdc-b1267046f559")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messagead97fb47-d2b9-4b6e-a15c-562d80380cee")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason1ecc9589-097e-4139-8c8f-93c2aaa8b313")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason76f671ee-9fe8-486d-bd53-996c71fc84be")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason8c766dba-3f26-4412-befc-0c88dc51c202")
aweXpect.Core.Tests.FailTests ‑ Unless_ShouldThrowException(condition: False, reason: "reason4b3db2d6-c12c-47bb-8c2a-e5b0e38ea9ac")
…

@vbreuss vbreuss merged commit 0a226a3 into main Sep 4, 2025
14 checks passed
@vbreuss vbreuss deleted the topic/re-enable-skipped-test branch September 4, 2025 04:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

🚀 Benchmark Results

Details

BenchmarkDotNet v0.14.0, Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763, 1 CPU, 4 logical and 2 physical cores
.NET SDK 8.0.413
[Host] : .NET 8.0.19 (8.0.1925.36514), X64 RyuJIT AVX2

Job=InProcess Toolchain=InProcessEmitToolchain IterationCount=15
LaunchCount=1 WarmupCount=10

Method Mean Error StdDev Gen0 Gen1 Allocated
Bool_aweXpect 209.6 ns 1.15 ns 1.02 ns 0.0300 - 504 B
Bool_FluentAssertions 243.6 ns 1.68 ns 1.57 ns 0.0567 - 952 B
Bool_TUnit 876.3 ns 11.18 ns 10.46 ns 0.1431 - 2408 B
Equivalency_aweXpect 319,547.8 ns 1,235.96 ns 1,156.12 ns 20.0195 0.9766 335556 B
Equivalency_FluentAssertions 2,137,326.0 ns 6,200.72 ns 5,496.77 ns 273.4375 46.8750 4584416 B
Equivalency_TUnit 681,012.7 ns 1,787.52 ns 1,672.05 ns 51.7578 2.9297 880545 B
Int_GreaterThan_aweXpect 243.6 ns 0.58 ns 0.54 ns 0.0486 - 816 B
Int_GreaterThan_FluentAssertions 244.0 ns 1.62 ns 1.44 ns 0.0730 - 1224 B
Int_GreaterThan_TUnit 1,148.1 ns 2.44 ns 2.29 ns 0.1774 - 2984 B
ItemsCount_AtLeast_aweXpect 478.9 ns 1.18 ns 1.05 ns 0.0873 - 1464 B
ItemsCount_AtLeast_FluentAssertions 511.5 ns 2.83 ns 2.37 ns 0.1192 - 2008 B
ItemsCount_AtLeast_TUnit 16,824.9 ns 33.40 ns 31.24 ns 1.6174 - 27480 B
String_aweXpect 412.1 ns 1.32 ns 1.24 ns 0.0734 - 1232 B
String_FluentAssertions 465.7 ns 1.92 ns 1.60 ns 0.1292 - 2168 B
String_TUnit 1,217.8 ns 2.90 ns 2.57 ns 0.1831 - 3072 B
StringArray_aweXpect 1,730.9 ns 5.95 ns 4.97 ns 0.1698 - 2856 B
StringArray_FluentAssertions 1,290.8 ns 4.41 ns 3.91 ns 0.2480 - 4152 B
StringArray_TUnit 3,134.7 ns 12.08 ns 11.30 ns 0.3128 - 5296 B
StringArrayInAnyOrder_aweXpect 2,161.7 ns 5.40 ns 4.78 ns 0.1793 - 3048 B
StringArrayInAnyOrder_FluentAssertions 147,216.4 ns 1,005.78 ns 940.81 ns 3.4180 - 63351 B
StringArrayInAnyOrder_TUnit 3,836.6 ns 11.12 ns 10.40 ns 0.3815 - 6488 B

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

👽 Mutation Results

Mutation testing badge

aweXpect

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

aweXpect.Core

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

github-actions Bot added a commit that referenced this pull request Sep 4, 2025
github-actions Bot added a commit that referenced this pull request Sep 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 9, 2025

This is addressed in release v2.23.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coverage Additional tests for edge cases or improvement of test coverage state: released The issue is released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants