fix: throw ArgumentException when expected is empty in IsOneOf (2)

Source/aweXpect/Helpers/ThrowHelper.cs

@@ -0,0 +1,9 @@
+using System;
+
+namespace aweXpect.Helpers;
+
+internal static class ThrowHelper
+{
+	public static ArgumentException EmptyCollection()
+		=> new("You have to provide at least one expected value!");
+}

Source/aweXpect/That/Chars/ThatChar.IsOneOf.cs

@@ -84,7 +84,7 @@ public ConstraintResult IsMetBy(char actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;

Source/aweXpect/That/Chars/ThatNullableChar.IsOneOf.cs

@@ -84,7 +84,7 @@ public ConstraintResult IsMetBy(char? actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;

Source/aweXpect/That/DateOnlys/ThatDateOnly.IsOneOf.cs

@@ -129,7 +129,7 @@ public ConstraintResult IsMetBy(DateOnly actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;

Source/aweXpect/That/DateOnlys/ThatNullableDateOnly.IsOneOf.cs

@@ -136,7 +136,7 @@ public ConstraintResult IsMetBy(DateOnly? actual)
 
 				if (!hasValues)
 				{
-					throw new ArgumentException("You have to provide at least one expected value!");
+					throw ThrowHelper.EmptyCollection();
 				}
 
 				Outcome = Outcome.Failure;

Source/aweXpect/That/DateTimeOffsets/ThatDateTimeOffset.IsOneOf.cs

@@ -130,7 +130,7 @@ public ConstraintResult IsMetBy(DateTimeOffset actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;

Source/aweXpect/That/DateTimeOffsets/ThatNullableDateTimeOffset.IsOneOf.cs

@@ -136,7 +136,7 @@ public ConstraintResult IsMetBy(DateTimeOffset? actual)
 
 				if (!hasValues)
 				{
-					throw new ArgumentException("You have to provide at least one expected value!");
+					throw ThrowHelper.EmptyCollection();
 				}
 
 				Outcome = Outcome.Failure;

Source/aweXpect/That/DateTimes/ThatDateTime.IsOneOf.cs

@@ -130,7 +130,7 @@ public ConstraintResult IsMetBy(DateTime actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;

Source/aweXpect/That/DateTimes/ThatNullableDateTime.IsOneOf.cs

@@ -136,7 +136,7 @@ public ConstraintResult IsMetBy(DateTime? actual)
 
 				if (!hasValues)
 				{
-					throw new ArgumentException("You have to provide at least one expected value!");
+					throw ThrowHelper.EmptyCollection();
 				}
 
 				Outcome = Outcome.Failure;

Source/aweXpect/That/Enums/ThatEnum.IsOneOf.cs

@@ -78,7 +78,23 @@ private sealed class IsOneOfConstraint<TEnum>(string it, ExpectationGrammars gra
 		public ConstraintResult IsMetBy(TEnum actual)
 		{
 			Actual = actual;
-			Outcome = expected.Any(value => actual.Equals(value)) ? Outcome.Success : Outcome.Failure;
+			bool hasValues = false;
+			foreach (TEnum? value in expected)
+			{
+				hasValues = true;
+				if (actual.Equals(value))
+				{
+					Outcome = Outcome.Success;
+					return this;
+				}
+			}
+
+			if (!hasValues)
+			{
+				throw ThrowHelper.EmptyCollection();
+			}
+
+			Outcome = Outcome.Failure;
 			return this;
 		}
 

Source/aweXpect/That/Enums/ThatNullableEnum.IsOneOf.cs

@@ -78,7 +78,23 @@ private sealed class IsOneOfConstraint<TEnum>(string it, ExpectationGrammars gra
 		public ConstraintResult IsMetBy(TEnum? actual)
 		{
 			Actual = actual;
-			Outcome = expected.Any(value => actual.Equals(value)) ? Outcome.Success : Outcome.Failure;
+			bool hasValues = false;
+			foreach (TEnum? value in expected)
+			{
+				hasValues = true;
+				if (actual.Equals(value))
+				{
+					Outcome = Outcome.Success;
+					return this;
+				}
+			}
+
+			if (!hasValues)
+			{
+				throw ThrowHelper.EmptyCollection();
+			}
+
+			Outcome = Outcome.Failure;
 			return this;
 		}
 

Source/aweXpect/That/Numbers/ThatNumber.IsOneOf.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using aweXpect.Core;
 using aweXpect.Core.Constraints;
 using aweXpect.Helpers;
@@ -217,7 +216,7 @@ public ConstraintResult IsMetBy(TNumber actual)
 		{
 			Actual = actual;
 			bool hasValues = false;
-			foreach (TNumber? value in expected)
+			foreach (TNumber value in expected)
 			{
 				hasValues = true;
 				if (options.IsWithinTolerance(actual, value))
@@ -229,7 +228,7 @@ public ConstraintResult IsMetBy(TNumber actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;
@@ -273,7 +272,7 @@ public ConstraintResult IsMetBy(TNumber? actual)
 		{
 			Actual = actual;
 			bool hasValues = false;
-			foreach (TNumber? value in expected)
+			foreach (TNumber value in expected)
 			{
 				hasValues = true;
 				if (options.IsWithinTolerance(actual, value))
@@ -285,7 +284,7 @@ public ConstraintResult IsMetBy(TNumber? actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;
@@ -341,7 +340,7 @@ public ConstraintResult IsMetBy(TNumber actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;
@@ -397,7 +396,7 @@ public ConstraintResult IsMetBy(TNumber? actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;
@@ -2421,7 +2420,7 @@ public ConstraintResult IsMetBy(TNumber actual)
 		{
 			Actual = actual;
 			bool hasValues = false;
-			foreach (TNumber? value in expected)
+			foreach (TNumber value in expected)
 			{
 				hasValues = true;
 				if (options.IsWithinTolerance(actual, value))
@@ -2433,7 +2432,7 @@ public ConstraintResult IsMetBy(TNumber actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;
@@ -2477,7 +2476,7 @@ public ConstraintResult IsMetBy(TNumber? actual)
 		{
 			Actual = actual;
 			bool hasValues = false;
-			foreach (TNumber? value in expected)
+			foreach (TNumber value in expected)
 			{
 				hasValues = true;
 				if (options.IsWithinTolerance(actual, value))
@@ -2489,7 +2488,7 @@ public ConstraintResult IsMetBy(TNumber? actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;
@@ -2545,7 +2544,7 @@ public ConstraintResult IsMetBy(TNumber actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;
@@ -2601,7 +2600,7 @@ public ConstraintResult IsMetBy(TNumber? actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;

Source/aweXpect/That/Objects/ThatObject.IsOneOf.cs

@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using System.Linq;
 using System.Runtime.CompilerServices;
 using aweXpect.Core;
 using aweXpect.Core.Constraints;
@@ -87,9 +86,23 @@ private sealed class IsOneOfConstraint<TSubject, TExpected>(
 		public ConstraintResult IsMetBy(TSubject actual)
 		{
 			Actual = actual;
-			Outcome = expected.Any(value => options.AreConsideredEqual(actual, value))
-				? Outcome.Success
-				: Outcome.Failure;
+			bool hasValues = false;
+			foreach (TExpected? value in expected)
+			{
+				hasValues = true;
+				if (options.AreConsideredEqual(actual, value))
+				{
+					Outcome = Outcome.Success;
+					return this;
+				}
+			}
+
+			if (!hasValues)
+			{
+				throw ThrowHelper.EmptyCollection();
+			}
+
+			Outcome = Outcome.Failure;
 			return this;
 		}
 

Source/aweXpect/That/Strings/ThatString.IsOneOf.cs

@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using System.Linq;
 using aweXpect.Core;
 using aweXpect.Core.Constraints;
 using aweXpect.Helpers;
@@ -82,10 +81,24 @@ public ConstraintResult IsMetBy(string? actual)
 		{
 			Actual = actual;
 			StringEqualityOptions stringEqualityOptions = options;
-			Outcome = expectedValues.Any(expectedValue => stringEqualityOptions
-				.AreConsideredEqual(actual, expectedValue))
-				? Outcome.Success
-				: Outcome.Failure;
+			bool hasValues = false;
+			foreach (string? value in expectedValues)
+			{
+				hasValues = true;
+				if (stringEqualityOptions
+				    .AreConsideredEqual(actual, value))
+				{
+					Outcome = Outcome.Success;
+					return this;
+				}
+			}
+
+			if (!hasValues)
+			{
+				throw ThrowHelper.EmptyCollection();
+			}
+
+			Outcome = Outcome.Failure;
 			return this;
 		}
 

Source/aweXpect/That/TimeOnlys/ThatNullableTimeOnly.IsOneOf.cs

@@ -136,7 +136,7 @@ public ConstraintResult IsMetBy(TimeOnly? actual)
 
 				if (!hasValues)
 				{
-					throw new ArgumentException("You have to provide at least one expected value!");
+					throw ThrowHelper.EmptyCollection();
 				}
 
 				Outcome = Outcome.Failure;

Source/aweXpect/That/TimeOnlys/ThatTimeOnly.IsOneOf.cs

@@ -130,7 +130,7 @@ public ConstraintResult IsMetBy(TimeOnly actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;

Source/aweXpect/That/TimeSpans/ThatNullableTimeSpan.IsOneOf.cs

@@ -132,7 +132,7 @@ public ConstraintResult IsMetBy(TimeSpan? actual)
 
 				if (!hasValues)
 				{
-					throw new ArgumentException("You have to provide at least one expected value!");
+					throw ThrowHelper.EmptyCollection();
 				}
 
 				Outcome = Outcome.Failure;

Source/aweXpect/That/TimeSpans/ThatTimeSpan.IsOneOf.cs

@@ -126,7 +126,7 @@ public ConstraintResult IsMetBy(TimeSpan actual)
 
 			if (!hasValues)
 			{
-				throw new ArgumentException("You have to provide at least one expected value!");
+				throw ThrowHelper.EmptyCollection();
 			}
 
 			Outcome = Outcome.Failure;

Tests/aweXpect.Tests/Chars/ThatChar.IsNotOneOf.Tests.cs

@@ -30,7 +30,7 @@ await That(Act).Throws<ArgumentException>()
 			[InlineData('\t')]
 			public async Task WhenExpectedOnlyContainsNull_ShouldSucceed(char subject)
 			{
-				IEnumerable<char?> expected = [null];
+				IEnumerable<char?> expected = [null,];
 
 				async Task Act()
 					=> await That(subject).IsNotOneOf(expected);
@@ -57,7 +57,7 @@ await That(Act).Throws<ArgumentException>()
 			public async Task WhenSubjectIsContained_ShouldFail(char subject,
 				params char[] otherValues)
 			{
-				IEnumerable<char> expected = [..otherValues, subject];
+				IEnumerable<char> expected = [..otherValues, subject,];
 
 				async Task Act()
 					=> await That(subject).IsNotOneOf(expected);

Tests/aweXpect.Tests/Chars/ThatChar.IsOneOf.Tests.cs

@@ -30,7 +30,7 @@ await That(Act).Throws<ArgumentException>()
 			[InlineData('\t')]
 			public async Task WhenExpectedOnlyContainsNull_ShouldFail(char subject)
 			{
-				IEnumerable<char?> expected = [null];
+				IEnumerable<char?> expected = [null,];
 
 				async Task Act()
 					=> await That(subject).IsOneOf(expected);
@@ -62,7 +62,7 @@ await That(Act).Throws<ArgumentException>()
 			public async Task WhenSubjectIsContained_ShouldSucceed(char subject,
 				params char[] otherValues)
 			{
-				IEnumerable<char> expected = [..otherValues, subject];
+				IEnumerable<char> expected = [..otherValues, subject,];
 
 				async Task Act()
 					=> await That(subject).IsOneOf(expected);