fix: verify that the duration is not negative

[vbreuss]

Throw an ArgumentOutOfRangeException when using .Within from #667 with a negative range.

[Copilot]

Pull Request Overview

This PR ensures that calling .Within with a negative TimeSpan immediately throws an ArgumentOutOfRangeException, and updates all existing tests to cover that scenario and adjust expected timestamps.

• Added a guard in the generic ThatDelegateThrows<TException>.Within to reject negative durations.
• Introduced negative-duration tests in all three .Within test classes (ThrowsException, ThrowsExactly, Throws).
• Updated existing tests to use 0.Seconds() and expect "0:00" in failure messages.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
Tests/aweXpect.Tests/Delegates/ThatDelegate.ThrowsException.Within.Tests.cs	Added negative-duration test and corrected expected timestamp strings.
Tests/aweXpect.Tests/Delegates/ThatDelegate.ThrowsExactly.Within.Tests.cs	Added negative-duration test and corrected expected timestamp strings.
Tests/aweXpect.Tests/Delegates/ThatDelegate.Throws.Within.Tests.cs	Added negative-duration test and corrected expected timestamp strings.
Source/aweXpect.Core/Delegates/ThatDelegateThrows.Within.cs	Added validation to throw on negative duration in generic .Within.

Comments suppressed due to low confidence (1)

Source/aweXpect.Core/Delegates/ThatDelegateThrows.Within.cs:13

• Negative-duration validation is implemented only in the generic overload. The non-generic .Within overload used by .Throws(Type) isn’t guarded and will not throw as expected. Add the same ArgumentOutOfRangeException check there.

		if (duration < TimeSpan.Zero)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

    4 files  ±0      4 suites  ±0   21s ⏱️ -1s
  897 tests ±0    896 ✅ ±0  1 💤 ±0  0 ❌ ±0 
2 577 runs  ±0  2 576 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 5c9b301. ± Comparison against base commit d037b01.

This pull request removes 54 and adds 54 tests. Note that renamed tests count towards both.

aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message5689f412-33f6-406e-8dcf-2ee76b372183")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message57dad460-6d99-4ef2-b92b-bac15944ce46")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "messagea9de4b9f-6e77-4510-ae95-3aefa2e5e9e1")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message17d8d8e1-190a-4b29-b859-2e3359bdf9ee")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message86040395-491d-4a24-aadb-3746e2f04c17")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messagefecca41b-eaab-4d3e-aa65-38ec636a3841")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore29b6a4b5-f7d9-435b-b93f-d646a4f15540")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore713efcdf-81bf-4c7a-855e-18697c290068")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore8a030e9b-37ee-4a8b-9215-e697ffa0df13")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason75dc3587-5ee1-4a08-b5fa-16984f0c4470")
…

aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message4927d1e6-7c0a-4685-bee7-ed6b8d6b122b")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message518cca3a-86d9-48f6-8ce9-79b8d8f91bec")
aweXpect.Core.Tests.Core.Exceptions.FailExceptionTests ‑ Message_ShouldBeSet(message: "message5a03da32-b879-48a9-a203-11dfbfd5dc9f")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "message021d13e2-330f-4ba3-9338-59a7e084a45a")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messageaa799524-73c5-4866-8957-54f75035c215")
aweXpect.Core.Tests.Core.Exceptions.SkipExceptionTests ‑ Message_ShouldBeSet(message: "messagee8663574-ecc1-465b-a8aa-a34a861602cb")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore377b42b3-2f80-4c82-adb9-f1c984fec3a3")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnore6921752d-6aed-4f83-afe7-71af40274505")
aweXpect.Core.Tests.Equivalency.EquivalencyOptionsExtensionsTests ‑ Generic_For_IgnoringMember_ShouldSetOptionForType(memberToIgnore: "memberToIgnoree570938d-deda-4a4d-a386-1ce14a114eb3")
aweXpect.Core.Tests.FailTests ‑ Test_ShouldThrowException(reason: "reason481cea51-ca10-49de-a435-770f1efb3682")
…

[github-actions]

This is addressed in release v2.18.1.