fix: add System.Memory for .NET Framework test projects#984
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the test build configuration to ensure .NET Framework (net48) test targets explicitly reference System.Memory, with the package version managed centrally, improving restore/build reliability for .NET Framework test runs.
Changes:
- Add a conditional
PackageReferencetoSystem.Memoryfor.NETFrameworktest targets. - Pin
System.Memoryvia central package management inDirectory.Packages.props.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/Directory.Build.props | Adds System.Memory as a conditional test dependency for .NETFramework targets. |
| Directory.Packages.props | Introduces a centrally-managed version entry for System.Memory. |
|
Test Results 102 files ±0 102 suites ±0 2h 24m 12s ⏱️ - 3m 34s Results for commit 695620f. ± Comparison against base commit e553b06. This pull request removes 109655 and adds 109649 tests. Note that renamed tests count towards both.This pull request removes 12552 skipped tests and adds 12552 skipped tests. Note that renamed tests count towards both. |
|
This is addressed in release v6.1.0. |
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the test build configuration to ensure .NET Framework (net48) test targets explicitly reference
System.Memory, with the package version managed centrally, improving restore/build reliability for .NET Framework test runs.Changes:
PackageReferencetoSystem.Memoryfor.NETFrameworktest targets.System.Memoryvia central package management inDirectory.Packages.props.