Skip to content

fix: run all real file system tests sequentially #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 2 commits into from
Mar 31, 2026
Merged

fix: run all real file system tests sequentially #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef4807
fix: run all real file system tests sequentially
vbreuss Mar 30, 2026
3a1e1ba
Review issue
vbreuss Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/Helpers/Testably.Abstractions.TestHelpers/FileSystemTestsAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public ValueTask OnTestDiscovered(DiscoveredTestContext context)
context.TestContext.Metadata.TestDetails.TestClassArguments[0] is FileSystemTestData
.Real)
{
context.AddParallelConstraint(new NotInParallelConstraint(["RealFileSystem"]));
context.AddParallelConstraint(new NotInParallelConstraint([nameof(RealFileSystem)]));
}

return _completedTask;
Expand Down
2 changes: 1 addition & 1 deletion Tests/Testably.Abstractions.Testing.Tests/FileSystem/FileStreamFactoryMockTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace Testably.Abstractions.Testing.Tests.FileSystem;

[NotInParallel(nameof(IDirectoryCleaner))]
[NotInParallel(nameof(RealFileSystem))]
public sealed class FileStreamFactoryMockTests : IDisposable
{
#region Test Setup
Expand Down
2 changes: 1 addition & 1 deletion Tests/Testably.Abstractions.Testing.Tests/FileSystem/FileSystemWatcherFactoryMockTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Testably.Abstractions.Testing.Tests.FileSystem;

[NotInParallel(nameof(IDirectoryCleaner))]
[NotInParallel(nameof(RealFileSystem))]
public sealed class FileSystemWatcherFactoryMockTests : IDisposable
{
#region Test Setup
Expand Down
2 changes: 1 addition & 1 deletion Tests/Testably.Abstractions.Testing.Tests/FileSystem/FileSystemWatcherMockTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace Testably.Abstractions.Testing.Tests.FileSystem;

[NotInParallel(nameof(IDirectoryCleaner))]
[NotInParallel(nameof(RealFileSystem))]
public sealed class FileSystemWatcherMockTests : IDisposable
{
#region Test Setup
Expand Down
2 changes: 1 addition & 1 deletion Tests/Testably.Abstractions.Testing.Tests/FileSystemInitializer/DirectoryCleanerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Testably.Abstractions.Testing.Tests.FileSystemInitializer;

[NotInParallel(nameof(IDirectoryCleaner))]
[NotInParallel(nameof(RealFileSystem))]
public class DirectoryCleanerTests
{
#region Test Setup
Expand Down
Loading