fix: Correctly handle absolute and multi-component directory paths#954
Merged
vbreuss merged 4 commits intoTestably:mainfrom Mar 8, 2026
Merged
fix: Correctly handle absolute and multi-component directory paths#954vbreuss merged 4 commits intoTestably:mainfrom
vbreuss merged 4 commits intoTestably:mainfrom
Conversation
Contributor
Author
|
While this fixes #941 without breaking any other functionality, I'm not quite happy with it. I had to introduce a constructor that's only used for this specific purpose. I would like to fully replace the other constructor that takes a |
vbreuss
reviewed
Mar 7, 2026
Tests/Testably.Abstractions.Testing.Tests/FileSystemInitializer/FileSystemInitializerTests.cs
Show resolved
Hide resolved
Source/Testably.Abstractions.Testing/Initializer/FileSystemInitializer.cs
Outdated
Show resolved
Hide resolved
jeyk
force-pushed
the
fix/absolutepaths-with-children
branch
from
22dd078 to
e7ed04b
Compare
|
This is addressed in release v5.3.1. |
This was referenced Mar 9, 2026
Closed
This was referenced Mar 17, 2026
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing a directory's children, pass the complete
Nameof the directory instead of aDirectoryInfoobject. This ensures that if a directory is initialized with a multi-component name such asC:\temp\mysubdir, its children are created at the correct depth.