Skip to content

fix: dot file entries not having hidden attribute on mac mock #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 3 commits into from
Feb 15, 2026
Merged

fix: dot file entries not having hidden attribute on mac mock #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd81c6b
fix: fixed dot file system entries not having hidden attribute when m…
pw-sgr Feb 12, 2026
22d9d0a
test: moved Attributes_WhenDotFile_ShouldHaveHiddenFlag from FileVers…
pw-sgr Feb 12, 2026
019023e
test: renamed InMemoryContainerTests.AdjustAttributes_LeadingDot_Shou…
pw-sgr Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/Testably.Abstractions.Testing/Storage/InMemoryContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,8 @@ public override string ToString()

internal FileAttributes AdjustAttributes(FileAttributes attributes)
{
if (_fileSystem.Execute.IsLinux &&
_fileSystem.Execute.Path.GetFileName(_location.FullPath).StartsWith('.'))
if ((_fileSystem.Execute.IsLinux || _fileSystem.Execute.IsMac)
&& _fileSystem.Execute.Path.GetFileName(_location.FullPath).StartsWith('.'))
{
attributes |= FileAttributes.Hidden;
}
Expand Down
4 changes: 2 additions & 2 deletions Tests/Testably.Abstractions.Testing.Tests/Storage/InMemoryContainerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public async Task AdjustAttributes_Encrypt_ShouldHaveEncryptedAttribute(string p

[Theory]
[AutoData]
public async Task AdjustAttributes_LeadingDot_ShouldBeHiddenOnLinux(string path)
public async Task AdjustAttributes_LeadingDot_ShouldBeHiddenOnUnix(string path)
{
path = "." + path;
MockFileSystem fileSystem = new();
Expand All @@ -60,7 +60,7 @@ public async Task AdjustAttributes_LeadingDot_ShouldBeHiddenOnLinux(string path)

FileAttributes result = container.AdjustAttributes(FileAttributes.Normal);

if (Test.RunsOnLinux)
if (!Test.RunsOnWindows)
{
await That(result).HasFlag(FileAttributes.Hidden);
}
Expand Down
15 changes: 15 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/File/GetAttributesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,19 @@ public async Task GetAttributes_ShouldReturnAttributes(

await That(result).IsEqualTo(attributes);
}

[Fact]
public async Task GetAttributes_WhenDotEntry_ShouldHaveHiddenFlag()
{
Skip.If(Test.RunsOnWindows);

const string path = ".env";
FileAttributes result;

FileSystem.File.WriteAllText(path, null);

result = FileSystem.File.GetAttributes(path);

await That(result).HasFlag(FileAttributes.Hidden);
}
}
26 changes: 26 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/FileSystemInfo/Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,4 +156,30 @@ public async Task SetAttributes_ShouldOnlyWork_OnWindows(FileAttributes attribut
await That(result).IsEqualTo(FileAttributes.Normal);
}
}

[Theory]
[AutoData]
public async Task Attributes_WhenDotFile_ShouldHaveHiddenFlag(bool isFile)
{
Skip.If(Test.RunsOnWindows);

const string path = ".env";

FileAttributes result;

if (isFile)
{
FileSystem.File.WriteAllText(path, null);

result = FileSystem.FileInfo.New(path).Attributes;
}
else
{
FileSystem.Directory.CreateDirectory(path);

result = FileSystem.DirectoryInfo.New(path).Attributes;
}

await That(result).HasFlag(FileAttributes.Hidden);
}
}
Loading