feat: add support for working with UnixFileMode
#826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive support for working with UnixFileMode in the Testably.Abstractions testing framework. The implementation provides Unix file permission simulation capabilities for the mock file system, enabling developers to test Unix-specific file permission behaviors in their code.
Key Changes
- Added
IUnixFileModeStrategyinterface and implementations for simulating Unix file permissions - Enhanced storage layer to enforce Unix file mode access controls
- Added comprehensive test coverage for Unix file mode behaviors across File, Directory, and DirectoryInfo operations
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
Tests/Testably.Abstractions.Tests/FileSystem/File/UnixFileModeTests.cs |
Added tests for file operations with Unix file mode restrictions |
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/UnixFileModeTests.cs |
New test file for DirectoryInfo Unix file mode behaviors |
Tests/Testably.Abstractions.Tests/FileSystem/Directory/UnixFileModeTests.cs |
New test file for Directory Unix file mode behaviors |
Tests/Testably.Abstractions.Testing.Tests/MockFileSystemTests.cs |
Added tests for Unix file mode strategy configuration and platform restrictions |
Tests/Api/Testably.Abstractions.Api.Tests/Expected/*.txt |
Updated API surface definitions to include new Unix file mode interfaces and classes |
Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs |
Enhanced storage enumeration and access control with Unix file mode support |
Source/Testably.Abstractions.Testing/Storage/InMemoryContainer.cs |
Added Unix file mode property and access validation to storage containers |
Source/Testably.Abstractions.Testing/Storage/IStorage.cs |
Updated interface to support parent access requests for Unix permission checks |
Source/Testably.Abstractions.Testing/MockFileSystem.cs |
Added Unix file mode strategy configuration and platform validation |
Source/Testably.Abstractions.Testing/Initializer/DirectoryCleaner.cs |
Enhanced directory cleanup to handle Unix file permissions |
Source/Testably.Abstractions.Testing/Helpers/ExceptionFactory.cs |
Added Unix file mode specific exception factory method |
Source/Testably.Abstractions.Testing/FileSystem/NullUnixFileModeStrategy.cs |
New null object implementation for Unix file mode strategy |
Source/Testably.Abstractions.Testing/FileSystem/IUnixFileModeStrategy.cs |
New interface defining Unix file mode simulation strategy |
Source/Testably.Abstractions.Testing/FileSystem/DirectoryMock.cs |
Enhanced directory operations to handle Unix file mode exceptions |
Source/Testably.Abstractions.Testing/FileSystem/DirectoryInfoMock.cs |
Enhanced DirectoryInfo operations to handle Unix file mode exceptions |
Tests/Testably.Abstractions.Tests/FileSystem/File/UnixFileModeTests.cs
Outdated
Show resolved
Hide resolved
Tests/Testably.Abstractions.Tests/FileSystem/File/UnixFileModeTests.cs
Outdated
Show resolved
Hide resolved
Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs
Outdated
Show resolved
Hide resolved
Source/Testably.Abstractions.Testing/FileSystem/NullUnixFileModeStrategy.cs
Outdated
Show resolved
Hide resolved
|
|
This is addressed in release v4.3.0. |
This was referenced Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive support for working with
UnixFileModein the Testably.Abstractions testing framework. The implementation provides Unix file permission simulation capabilities for the mock file system, enabling developers to test Unix-specific file permission behaviors in their code.Key Changes
IUnixFileModeStrategyinterface and implementations for simulating Unix file permissions