fix: enumerate directories with trailing slash #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #802 by ensuring that directories with trailing slashes are properly enumerated. The fix addresses a bug where GetFileName was not handling directory paths with trailing separators correctly.
- Adds logic to trim trailing directory separators before calling
GetFileNamein enumeration - Includes a test case to verify empty directories with trailing slashes are properly enumerated
- Contains an unrelated formatting change to lambda expression formatting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| EnumerateDirectoriesTests.cs | Adds test case to verify directories with trailing slashes are enumerated correctly |
| InMemoryStorage.cs | Fixes enumeration logic to handle trailing directory separators and includes minor formatting change |
Comments suppressed due to low confidence (1)
Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs:255
- [nitpick] The variable name 'itemPath' is somewhat redundant since it's derived from 'item.Key.FullPath'. Consider a more descriptive name like 'normalizedPath' or 'pathWithoutTrailingSlash' to better reflect its purpose after the trimming operation.
string? itemPath = item.Key.FullPath;
Tests/Testably.Abstractions.Tests/FileSystem/Directory/EnumerateDirectoriesTests.cs
Outdated
Show resolved
Hide resolved
…teDirectoriesTests.cs Co-authored-by: Copilot <[email protected]>
|
Test Results 37 files ± 0 37 suites ±0 15m 47s ⏱️ -2s Results for commit 0e55b41. ± Comparison against base commit d3f8cdb. This pull request removes 35206 and adds 35213 tests. Note that renamed tests count towards both.This pull request removes 1754 skipped tests and adds 1754 skipped tests. Note that renamed tests count towards both. |
|
This is addressed in release v4.2.1. |
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that directories with trailing slashes are properly enumerated.
GetFileNamein enumeration