Skip to content

refactor: skip brittle tests on MacOS #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2025
Merged

refactor: skip brittle tests on MacOS #798

merged 4 commits into from
Jul 11, 2025

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Jul 11, 2025 •
edited
Loading

Tests for FileSystemWatcher notifications on other filters are brittle on MacOS. Skip them for the time being.

@vbreuss
refactor: increase timeout in tests
01dec5c 
Some timing related tests are brittle on the build system, due to limited resources (timeout of 500ms is not always sufficient).
Therefore increase the timeout in Release mode to 2 seconds.
@vbreuss vbreuss self-assigned this Jul 11, 2025
@vbreuss vbreuss added the refactor A change or improvement without functional impact label Jul 11, 2025
@vbreuss vbreuss changed the title refactor: increase timeout in tests refactor: skip brittle tests on MacOS Jul 11, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vbreuss vbreuss enabled auto-merge (squash) July 11, 2025 05:21
@vbreuss vbreuss merged commit 4eaef90 into main Jul 11, 2025
14 checks passed
@vbreuss vbreuss deleted the topic/incerease-test-timeout branch July 11, 2025 05:29
@github-actions
Copy link

github-actions bot commented Jul 11, 2025

Test Results

    37 files  ±0      37 suites  ±0   15m 34s ⏱️ -51s
42 915 tests +1  40 536 ✅  - 68  2 379 💤 +70  0 ❌  - 1 
84 129 runs  ±0  75 339 ✅  - 69  8 790 💤 +70  0 ❌  - 1 

Results for commit 3109359. ± Comparison against base commit df53d7b.

This pull request removes 35051 and adds 35052 tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path28b1445a-d05e-46f7-bb9b-62cfff92dfcb")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5ee58c2b-8fbd-4e88-83b1-6e4c9591a485")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7b765c13-489c-480e-9a58-ad7c57368c9f")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "patha9e3da0d-f613-4ff8-9b9c-27b412ae423a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathbfe83e47-7f09-409f-a77c-6d5a2bffca30")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdb9ec98d-6514-45a8-ad0a-20df15288016")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathefbabbe9-ff7a-4546-8ff7-384fd2f1963f")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path4d61e728-fc15-43b9-a7c1-2406b6dc898e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5fc31b5f-08cf-4f68-8429-d28dda191bd8")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path83fba870-9a12-45b1-8f2c-eade26cc04a5")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path06ff6ab7-c7e7-4783-bc0e-56d48c378aaf")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path0869fd70-bc30-47f8-9e5b-780d8ae349dc")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path13f3e9fe-2c97-475e-9088-0aad29edc2b7")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path4c805f1f-f2cd-4f7d-b667-5233ca3df102")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7f7abf38-94b6-4356-bcca-40aa69459994")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path93ca229a-ae53-405f-8ad0-47cee700feeb")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathab8c1cc3-8469-460c-b065-efeeb051c9c3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path087d4e90-7eb5-4dc7-9dd0-17a8e328e34a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3906c295-3e16-4f0a-918a-51fc1d999627")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3d0a3f54-1834-4d8b-b85e-008267ee91da")
…
This pull request removes 1684 skipped tests and adds 1754 skipped tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path28b1445a-d05e-46f7-bb9b-62cfff92dfcb")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7b765c13-489c-480e-9a58-ad7c57368c9f")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "patha9e3da0d-f613-4ff8-9b9c-27b412ae423a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdb9ec98d-6514-45a8-ad0a-20df15288016")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5fc31b5f-08cf-4f68-8429-d28dda191bd8")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "patha415d34a-2bae-4669-aa59-4f15c8761094")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathaa4c565b-5e54-4685-8f9a-87c7f07ffd8c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathc1a11bfd-50f6-4d69-b896-85281b328989")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path662b517e-1ca6-4209-bd6f-6c4bef981d59")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path818acb8f-49f0-477f-8797-35ed86c3c23e")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path0869fd70-bc30-47f8-9e5b-780d8ae349dc")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7f7abf38-94b6-4356-bcca-40aa69459994")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path93ca229a-ae53-405f-8ad0-47cee700feeb")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathab8c1cc3-8469-460c-b065-efeeb051c9c3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3906c295-3e16-4f0a-918a-51fc1d999627")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3d0a3f54-1834-4d8b-b85e-008267ee91da")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path4caa0a54-a365-4b49-a4a7-9ccc72fa7f7a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd242742f-2a36-4408-a982-e00956b9d314")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path3b3e799e-40c4-461f-a19c-e66fdf4987ac")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path54bedb1c-8f97-47e8-ad95-c43505574d38")
…

@github-actions
Copy link

github-actions bot commented Jul 11, 2025

This is addressed in release v4.1.0.

@dependabot dependabot bot mentioned this pull request Aug 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vbreuss vbreuss

Labels

refactor A change or improvement without functional impact state: released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss