Skip to content

refactor: remove NCrunch from test projects #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

refactor: remove NCrunch from test projects #765

merged 1 commit into from
Mar 13, 2025

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Mar 13, 2025 •
edited
Loading

Consolidate NCrunch target framework in the Directory.Build.props file for tests.

@vbreuss vbreuss added the refactor A change or improvement without functional impact label Mar 13, 2025
@vbreuss vbreuss self-assigned this Mar 13, 2025
@vbreuss vbreuss enabled auto-merge (squash) March 13, 2025 08:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vbreuss vbreuss merged commit c8d2c32 into main Mar 13, 2025
15 checks passed
@vbreuss vbreuss deleted the topic/remove-ncrunch-from-projects branch March 13, 2025 08:49
@github-actions
Copy link

github-actions bot commented Mar 13, 2025

Test Results

     52 files  ±0       52 suites  ±0   23m 11s ⏱️ +14s
 58 626 tests  - 4   55 596 ✅  - 4   3 030 💤 ±0  0 ❌ ±0 
121 582 runs  ±0  108 951 ✅ ±0  12 631 💤 ±0  0 ❌ ±0 

Results for commit 31f34e6. ± Comparison against base commit 7568b19.

This pull request removes 50768 and adds 50764 tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5d193460-4abf-4b35-964f-bec1bc90ca24")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path66d9bdad-8265-4f20-b200-dd097a226479")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7f988712-0ed6-44f8-8c8c-0ce81ecf4ff4")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path82e5e237-4aba-42fc-a007-2bc19fe1dfd2")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path97223893-b156-47e7-b113-6cb55ee6052d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathad86be75-74ef-48e0-ab1b-d091032bca96")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathc934cbc8-a8dc-45a0-a008-3356e37ab03e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathcd0dde50-d40c-4aa0-aa4d-0f408b11283e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd7c63154-300e-4bbc-b21f-7b30b3a1aebc")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathfc37632b-05d0-4495-acf8-d9e4101e03f8")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path02032454-e001-4417-8a97-b698ed011250")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path157d3e07-a0eb-4896-84b8-07a7d582507d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3ddf7e79-3cdd-438f-b64a-4ec1ddae6243")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path57b93257-093d-418e-a124-66475e233251")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7d469ce2-28a8-44e0-9702-7f74a38ab86a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathbe9bf715-5f15-4436-8e02-6286858ea3c8")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathcf30194c-a5bf-43a2-8c13-6bced9eb874f")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdb4167e3-a975-41bc-b4d8-83efc694548b")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe35b9556-6edb-436e-b9fd-c2ec8227b0e2")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathf9a3f031-3c0b-4c03-ba72-38fae78c8b56")
…
This pull request removes 2411 skipped tests and adds 2411 skipped tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5d193460-4abf-4b35-964f-bec1bc90ca24")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path97223893-b156-47e7-b113-6cb55ee6052d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathad86be75-74ef-48e0-ab1b-d091032bca96")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathc934cbc8-a8dc-45a0-a008-3356e37ab03e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd7c63154-300e-4bbc-b21f-7b30b3a1aebc")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathfc37632b-05d0-4495-acf8-d9e4101e03f8")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path325f0a12-e82c-4ef6-975d-ee8aa0cf23e1")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path342b577f-084c-4e86-89d8-013603629798")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path460e6789-1c8c-4508-beb7-adef7acc16b6")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path59f82ea4-a6c7-467c-a495-c713c2168089")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path02032454-e001-4417-8a97-b698ed011250")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path57b93257-093d-418e-a124-66475e233251")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7d469ce2-28a8-44e0-9702-7f74a38ab86a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathbe9bf715-5f15-4436-8e02-6286858ea3c8")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathcf30194c-a5bf-43a2-8c13-6bced9eb874f")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdb4167e3-a975-41bc-b4d8-83efc694548b")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1e434bcb-12f8-4c40-bf1f-45abddc49bfe")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5b65d31a-c26b-4de7-9f95-ea296bce851d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6ea89171-d42a-4a0a-9d65-a0a3f49f3d3e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path95692854-06e1-424a-b7a9-ac36bacfb0d9")
…

@github-actions
Copy link

github-actions bot commented Mar 13, 2025

This is addressed in release v4.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vbreuss vbreuss

Labels

refactor A change or improvement without functional impact state: released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss