Skip to content

refactor!: remove support for .NET7 #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2025
Merged

refactor!: remove support for .NET7 #729

merged 2 commits into from
Jan 25, 2025

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Jan 25, 2025 •
edited
Loading

As .NET 7 is out of support since May 14, 2024, remove explicit support from Testably.Abstractions.

@vbreuss vbreuss added the refactor A change or improvement without functional impact label Jan 25, 2025
@vbreuss vbreuss self-assigned this Jan 25, 2025
@vbreuss vbreuss enabled auto-merge (squash) January 25, 2025 05:59
@vbreuss vbreuss added the breaking change The changes require a new major version label Jan 25, 2025
@github-actions
Copy link

github-actions bot commented Jan 25, 2025 •
edited
Loading

👽 Mutation Results

Mutation testing badge

Testably.Abstractions.Testing

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants
FileSystem/DirectoryMock.cs 42.03% 29 2 0 38 19 4 29 40 92
FileSystem/FileMock.cs 15.38% 24 19 0 113 104 6 24 132 266
FileSystem/FileSystemWatcherMock.cs 5.22% 7 5 0 122 60 4 7 127 198
FileSystem/PathMock.cs 95.92% 47 2 0 0 5 0 47 2 54
Helpers/Execute.NativePath.cs 58.82% 10 4 0 3 5 0 10 7 22
Helpers/Execute.SimulatedPath.cs 25.82% 87 0 0 250 89 2 87 250 428
Storage/NullContainer.cs 22.22% 2 2 0 5 7 0 2 7 16

The final mutation score is 26.72%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.AccessControl

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.Compression

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants
ZipArchiveEntryWrapper.cs 100.00% 7 0 0 0 3 0 7 0 10
ZipArchiveWrapper.cs 100.00% 10 0 0 0 8 0 10 0 18

The final mutation score is 100.00%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants
FileSystem\DirectoryWrapper.cs 100.00% 1 0 0 0 0 0 1 0 1
FileSystem\FileSystemWatcherWrapper.cs 27.27% 3 8 0 0 3 0 3 8 14
FileSystem\FileWrapper.cs 100.00% 1 0 0 0 0 0 1 0 1
FileSystem\PathWrapper.cs 100.00% 1 0 0 0 0 0 1 0 1

The final mutation score is 42.86%

Coverage Thresholds: high:80 low:60 break:0

@vbreuss vbreuss disabled auto-merge January 25, 2025 06:08
@vbreuss vbreuss enabled auto-merge (squash) January 25, 2025 06:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Jan 25, 2025 •
edited
Loading

Test Results

    31 files   -     15      31 suites   - 15   15m 19s ⏱️ - 7m 29s
39 227 tests  - 15 968  37 056 ✅  - 15 164  2 171 💤  -   803  0 ❌  - 1 
76 371 runs   - 38 444  68 230 ✅  - 34 283  8 141 💤  - 4 160  0 ❌  - 1 

Results for commit 0ef0d3c. ± Comparison against base commit d1008af.

This pull request removes 47554 and adds 31586 tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path54f3b57b-41ea-4648-9872-7d4ab8fad567")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6cf3ad12-81f6-43df-be40-5a16d791defe")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathcfd8b607-eb44-44b5-a718-86c8fd073d33")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd76f2bed-bf79-4fe7-98a5-0295cf44fd91")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathde8ae58c-33b4-4604-964f-464211344056")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe9c0d6e5-0058-4750-a018-6a233272d758")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathf820e563-d392-4261-9988-596d4e3e6364")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathf8ca90b3-d6a3-4527-82c1-b6d91c235ba7")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathfb801bfc-1cab-45eb-9f20-bfba777786f2")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path063faec1-532c-4cae-be37-3a4920fbed6c")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1f78e41e-c28e-4869-bfb7-0345fdb3dd6e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2fb65d2a-2a43-4cad-99f5-ff07034d402f")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3ebe411f-d58f-4603-a35a-58e32d790298")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "patha03265d7-5230-459e-8265-8c83b6ed6c8e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathda854230-cd64-498b-8ea6-82b6bbe49352")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathf4465ae5-87f2-4d93-9aa7-f792dffa607a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2c49c3a8-0ee2-46a3-bdde-8520357f7372")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path57ec311b-ad63-4f4c-ab43-dca3a46d068d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6cc8ec6f-bdf0-4757-b195-18a1d54b82f1")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path78e80806-7057-4adb-971c-a13bed1f23ad")
…
This pull request removes 2351 skipped tests and adds 1548 skipped tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path54f3b57b-41ea-4648-9872-7d4ab8fad567")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathcfd8b607-eb44-44b5-a718-86c8fd073d33")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathde8ae58c-33b4-4604-964f-464211344056")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe9c0d6e5-0058-4750-a018-6a233272d758")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathf820e563-d392-4261-9988-596d4e3e6364")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathf8ca90b3-d6a3-4527-82c1-b6d91c235ba7")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path063faec1-532c-4cae-be37-3a4920fbed6c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3bb89bb1-c918-4319-a507-f572ea94c3f6")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path4c6d1c5e-49f8-4ea0-814f-7ce6ecf6ee0d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path50696f6f-062c-49fa-b2f7-c1e152989b29")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1f78e41e-c28e-4869-bfb7-0345fdb3dd6e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3ebe411f-d58f-4603-a35a-58e32d790298")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "patha03265d7-5230-459e-8265-8c83b6ed6c8e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathf4465ae5-87f2-4d93-9aa7-f792dffa607a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2c49c3a8-0ee2-46a3-bdde-8520357f7372")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path57ec311b-ad63-4f4c-ab43-dca3a46d068d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6cc8ec6f-bdf0-4757-b195-18a1d54b82f1")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path78e80806-7057-4adb-971c-a13bed1f23ad")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path01fe8e23-bc47-434b-92fe-7558e744a42e")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathe8d58d4d-6884-4797-8606-1082cea12009")
…

♻️ This comment has been updated with latest results.

@vbreuss vbreuss merged commit ea05a39 into main Jan 25, 2025
14 checks passed
@vbreuss vbreuss deleted the topic/disable-net7-support branch January 25, 2025 06:45
@vbreuss vbreuss restored the topic/disable-net7-support branch January 29, 2025 14:59
@github-actions
Copy link

github-actions bot commented Feb 1, 2025

This is addressed in release v4.0.0.

@vbreuss vbreuss deleted the topic/disable-net7-support branch August 11, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vbreuss vbreuss

Labels

breaking change The changes require a new major version refactor A change or improvement without functional impact state: released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss