Skip to content

refactor: fix analyzer warnings (3) #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 13, 2025
Merged

refactor: fix analyzer warnings (3) #713

merged 5 commits into from
Jan 13, 2025

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Jan 12, 2025

Continuing to fix the analyzer warnings (see #711)

@vbreuss vbreuss added the refactor A change or improvement without functional impact label Jan 12, 2025
@vbreuss vbreuss self-assigned this Jan 12, 2025
@vbreuss vbreuss enabled auto-merge (squash) January 12, 2025 18:52
@github-actions
Copy link

github-actions bot commented Jan 12, 2025 •
edited
Loading

👽 Mutation Results

Mutation testing badge

Testably.Abstractions.Testing

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants
Helpers/FileSystemExtensions.cs 4.65% 2 0 0 41 14 6 2 41 63
Helpers/FileSystemRegistration.cs 100.00% 13 0 0 0 4 0 13 0 17
MockFileSystem.cs 85.71% 18 0 0 3 5 0 18 3 26
Storage/InMemoryContainer.cs 0.00% 0 0 0 105 36 1 0 105 142
Storage/InMemoryStorage.cs 7.22% 21 1 0 269 103 71 21 270 465
TimeProvider.cs 100.00% 3 0 0 0 3 0 3 0 6

The final mutation score is 11.97%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.AccessControl

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.Compression

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

@github-actions
Copy link

github-actions bot commented Jan 12, 2025 •
edited
Loading

Test Results

     46 files  ±0       46 suites  ±0   22m 24s ⏱️ +16s
 55 197 tests +2   52 223 ✅ +2   2 974 💤 ±0  0 ❌ ±0 
114 815 runs  ±0  102 514 ✅ ±0  12 301 💤 ±0  0 ❌ ±0 

Results for commit b9030a4. ± Comparison against base commit faa8c67.

This pull request removes 47532 and adds 47534 tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1a45801b-03f6-4eb9-933d-9f445b9380e5")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3d095b53-bf55-4e98-9838-8d29fa124ae5")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3de29a44-5d10-4c25-9831-332d347e7122")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path4042e461-5617-4e05-a628-0e4a48e7c09b")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path522ec0cc-4c52-4025-87c1-97c19ef90de3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7418510a-b67c-4d69-a921-dbbe1a5c09a5")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathae209a46-df15-4f81-a5f5-f045d4531fa6")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd9de65aa-8539-4bce-a40c-11471189aa96")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathed16ab33-4a29-420e-929d-1d3af9420e85")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path05276b9d-4f12-4e69-823d-1e139ab6e54c")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2730fc66-96c6-471b-9af4-45dbbe2d4f0c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path298a97d8-a0fe-4032-b78d-b2537900ae75")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5ea47747-d4fe-4acb-bd6d-c145377cfb5c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6bd39d5e-6a95-4ff7-951a-6a9dc05b5c07")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6c65797e-a539-4935-a449-b477a7a509ba")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path9edbc0fb-9023-42e3-9d69-8574cdfec980")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathabc11ad1-7226-45f5-8c60-507d68f67502")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathc8bc3e84-22b1-4896-aa33-c6e6604335bf")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdaae0f3d-b684-4344-8b7e-2a6aaa75baae")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path0227cd5c-a9f8-4cad-b14a-f7079c7cf9cf")
…
This pull request removes 2351 skipped tests and adds 2351 skipped tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path3de29a44-5d10-4c25-9831-332d347e7122")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path4042e461-5617-4e05-a628-0e4a48e7c09b")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path522ec0cc-4c52-4025-87c1-97c19ef90de3")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7418510a-b67c-4d69-a921-dbbe1a5c09a5")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathae209a46-df15-4f81-a5f5-f045d4531fa6")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd9de65aa-8539-4bce-a40c-11471189aa96")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path05276b9d-4f12-4e69-823d-1e139ab6e54c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path0548cd03-201a-4726-9c9d-b9cd4cdc1787")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5630a9ce-695e-4cc3-9e0d-8ea56422cc53")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5854e15e-645d-4c4f-83ee-c309ba197eb0")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path298a97d8-a0fe-4032-b78d-b2537900ae75")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5ea47747-d4fe-4acb-bd6d-c145377cfb5c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6bd39d5e-6a95-4ff7-951a-6a9dc05b5c07")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6c65797e-a539-4935-a449-b477a7a509ba")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path9edbc0fb-9023-42e3-9d69-8574cdfec980")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathabc11ad1-7226-45f5-8c60-507d68f67502")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path592d9d35-81ed-4dd2-a0da-62f48558744d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path61ef7a5b-0bab-4642-8999-5a4f15f26d57")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6deacf1d-2add-483d-b637-91611a316ef6")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path96cde66f-658a-4057-b41b-ce69c3caa677")
…

♻️ This comment has been updated with latest results.

@vbreuss vbreuss disabled auto-merge January 13, 2025 10:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vbreuss vbreuss enabled auto-merge (squash) January 13, 2025 11:16
@vbreuss vbreuss merged commit b6f978e into main Jan 13, 2025
14 checks passed
@vbreuss vbreuss deleted the topic/fix-sonar-issues-3 branch January 13, 2025 11:30
@github-actions
Copy link

github-actions bot commented Feb 1, 2025

This is addressed in release v4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vbreuss vbreuss

Labels

refactor A change or improvement without functional impact state: released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss