Skip to content

refactor: fix analyzer warnings #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 12, 2025
Merged

refactor: fix analyzer warnings #709

merged 4 commits into from
Jan 12, 2025

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Jan 11, 2025 •
edited
Loading

Fix the following analyzer warnings:

@vbreuss vbreuss added the refactor A change or improvement without functional impact label Jan 11, 2025
@vbreuss vbreuss self-assigned this Jan 11, 2025
@github-actions
Copy link

github-actions bot commented Jan 11, 2025 •
edited
Loading

👽 Mutation Results

Mutation testing badge

Testably.Abstractions.Testing

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants
FileSystem/FileMock.cs 15.38% 24 19 0 113 104 6 24 132 266
FileSystem/FileSystemWatcherMock.cs 6.72% 9 3 0 122 60 4 9 125 198
FileSystem/FileVersionInfoMock.cs 0.00% 0 0 0 54 1 0 0 54 55
Helpers/ChangeDescriptionExtensions.cs 0.00% 0 0 0 15 5 0 0 15 20
Helpers/Execute.SimulatedPath.cs 25.82% 87 0 0 250 89 2 87 250 428
Helpers/Execute.WindowsPath.cs 38.46% 75 0 0 120 25 10 75 120 230
Helpers/RandomSystemExtensions.cs 96.77% 30 1 0 0 1 0 30 1 32
Storage/InMemoryContainer.cs 0.00% 0 0 0 105 36 1 0 105 142
Storage/InMemoryStorage.cs 7.22% 21 1 0 269 103 71 21 270 465
Storage/NullContainer.cs 22.22% 2 2 0 5 7 0 2 7 16
Storage/StorageExtensions.cs 11.54% 3 0 0 23 7 1 3 23 34
TimeSystem/TimerMock.cs 87.04% 93 12 1 2 34 8 94 14 150

The final mutation score is 23.61%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.AccessControl

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.Compression

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

@github-actions
Copy link

github-actions bot commented Jan 11, 2025 •
edited
Loading

Test Results

     46 files  ± 0       46 suites  ±0   22m 6s ⏱️ -22s
 55 190 tests  - 55   52 216 ✅  - 55   2 974 💤 ±0  0 ❌ ±0 
114 806 runs  ± 0  102 505 ✅ ± 0  12 301 💤 ±0  0 ❌ ±0 

Results for commit 9e50074. ± Comparison against base commit ef0eac7.

This pull request removes 47582 and adds 47527 tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path43c6368e-58b9-4919-8135-177153a9058a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path46047747-7e05-40c6-af1d-e8641bea00c4")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path46d8573a-5e17-4081-b8ba-694b4612bc65")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path490c0565-cd05-47e5-b174-5937ed644143")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path581e286c-0064-4875-abc2-41bcbe0e9954")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path61d8d27b-2ab0-47b0-a089-924415cfddce")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path7dde229d-24cf-4791-b1fe-5670bc8b3a10")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd606f08b-3f71-42a1-906b-ccdaee97352c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathfd2cc3cc-8897-4526-b1e1-b90ff46fb187")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path17e6f3ef-4dff-40c3-a460-f8e150948d03")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path36f85226-cb4d-43cb-9e60-5edc4a9fba9b")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path375bad13-95c5-45f3-a45a-ba83fde25e30")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path4943ee67-ad3e-4a83-9f2f-45acc5eedf1e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5960b26f-d235-4f1c-bdfa-b63ba9a7cace")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6eeee339-edcd-48cc-8289-140cfcb13217")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path91b76cb2-82e2-4b0e-98d5-82744f49281a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathba8aee9c-f387-4412-b5b7-7a25a44296bb")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathbcc53d0c-2e30-4d1f-a572-18bb54fef307")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe5e76fa7-23a6-471e-9f31-f18057d631ae")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1be482e5-4ea7-4f58-8bc1-0cbfdd56e54c")
…
This pull request removes 2351 skipped tests and adds 2351 skipped tests. Note that renamed tests count towards both. 
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path46047747-7e05-40c6-af1d-e8641bea00c4")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path46d8573a-5e17-4081-b8ba-694b4612bc65")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path490c0565-cd05-47e5-b174-5937ed644143")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path61d8d27b-2ab0-47b0-a089-924415cfddce")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathd606f08b-3f71-42a1-906b-ccdaee97352c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathfd2cc3cc-8897-4526-b1e1-b90ff46fb187")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path17e6f3ef-4dff-40c3-a460-f8e150948d03")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path182349bb-b6b8-446d-86ec-94aefebff5ef")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1c8d0614-e5f9-4547-8d0d-e5c75fc8a0cb")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path56d71ea2-0927-4dc6-84f1-291df96ff9f7")
…

Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path375bad13-95c5-45f3-a45a-ba83fde25e30")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path5960b26f-d235-4f1c-bdfa-b63ba9a7cace")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path6eeee339-edcd-48cc-8289-140cfcb13217")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path91b76cb2-82e2-4b0e-98d5-82744f49281a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathbcc53d0c-2e30-4d1f-a572-18bb54fef307")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe5e76fa7-23a6-471e-9f31-f18057d631ae")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1be482e5-4ea7-4f58-8bc1-0cbfdd56e54c")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1d5bdd91-b495-453a-b157-5c41b8cbf25e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path71965eae-fd6a-4eff-86c8-860207357116")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests.RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path8aa6c123-77ef-46c8-9de9-0e22aa542bbf")
…

♻️ This comment has been updated with latest results.

@vbreuss vbreuss force-pushed the topic/fix-warnings branch from f7491b4 to 9e50074 Compare January 11, 2025 16:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vbreuss vbreuss marked this pull request as ready for review January 12, 2025 00:11
@vbreuss vbreuss merged commit 3493a95 into main Jan 12, 2025
14 checks passed
@vbreuss vbreuss deleted the topic/fix-warnings branch January 12, 2025 00:11
@vbreuss vbreuss mentioned this pull request Jan 12, 2025
Merged
@github-actions
Copy link

github-actions bot commented Feb 1, 2025

This is addressed in release v4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vbreuss vbreuss

Labels

refactor A change or improvement without functional impact state: released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss