Skip to content

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Dec 16, 2024

Update remaining tests in Compression.Tests remaining from #685

@vbreuss vbreuss added the refactor A change or improvement without functional impact label Dec 16, 2024
@vbreuss vbreuss self-assigned this Dec 16, 2024
@vbreuss vbreuss enabled auto-merge (squash) December 16, 2024 19:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
11 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

Test Results

   46 files  ±0     46 suites  ±0   2m 9s ⏱️ +15s
3 158 tests +1  3 118 ✅ +1   40 💤 ±0  0 ❌ ±0 
8 747 runs  ±0  8 542 ✅ ±0  205 💤 ±0  0 ❌ ±0 

Results for commit 0867979. ± Comparison against base commit 0415b2e.

This pull request removes 2377 and adds 2378 tests. Note that renamed tests count towards both.
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [144, 2, 206])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [174, 192, 216])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [226, 39, 58])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [240, 94, 149])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [253, 45, 178])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [28, 89, 186])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [6, 137, 172])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [89, 34, 40])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [97, 238, 155])
Testably.Abstractions.Testing.Tests.FileSystem.ChangeDescriptionTests ‑ ToString_ShouldIncludeChangeType(changeType: Created, fileSystemType: Directory, notifyFilters: FileName, path: "path15dadf58-fcb3-427d-aadf-16e029dd587c")
…
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [12, 174, 39])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [128, 129, 148])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [211, 159, 135])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [220, 224, 151])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [220, 3, 58])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [25, 77, 206])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [53, 100, 198])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [68, 130, 111])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [80, 173, 34])
Testably.Abstractions.Testing.Tests.FileSystem.ChangeDescriptionTests ‑ ToString_ShouldIncludeChangeType(changeType: Created, fileSystemType: Directory, notifyFilters: FileName, path: "path021508ff-7679-4123-9ba0-ccaf71828127")
…
This pull request removes 39 skipped tests and adds 39 skipped tests. Note that renamed tests count towards both.
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path5072fb7f-0a46-46ba-ac5c-024f1fcf6528")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathada3b4ff-9655-485b-ae80-888ee90104c9")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathc5e867d9-4f9a-427b-8f58-11729977d916")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathe3e276d5-9dd5-4b5b-b08b-958ed68ae5af")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "path1ddf25a0-692b-4103-b4a6-be45077801dd", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "path2de4968e-5165-4cc4-a257-8562d2e737df", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path1051ae235-5044-47fe-bba5-9198f2226d72", path2: "path26094b501-d1c6-4acd-a581-e471ce394d8b")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path15dc88d6c-fdb8-44ef-9984-65978ee15051", path2: "path2ee9d469b-05d0-48ac-8811-c97f091f8e13")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path1729b4b0e-b4f7-4b68-a67b-dcfbc6856c67", path2: "path2acd44aae-44c7-4c65-a338-aad278ea9cb7")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path17ad938b3-5d95-42f1-a0ca-62475a382821", path2: "path2b39fc448-8123-446c-9649-fbb0f1e2f380")
…
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path68f6306a-d4d9-4214-9a3c-39aaade35cac")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path9e0c90ee-db66-4e6e-a244-ae349736d6f2")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathabf7ff24-1d2b-49a8-a4c1-8365dd2a1770")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathac82195e-9605-4914-84e2-cb776c12d62f")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "path19a1908e-cc58-452f-86e6-d4a02a4d647f", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "pathaa72fca9-209a-46e6-b1d7-a03cb1561edd", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path1055feff4-026b-40f7-ac25-0018a7b000b7", path2: "path29eae5fd0-74bd-4509-8c9f-fe32aed46ece")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path12aaa975b-4901-46cc-8e2f-e034f9b9b7b2", path2: "path231e68fa2-6f5e-41d7-b53f-f82820a2ef59")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path12bdf3a94-b5fe-4e53-954c-f0cc1bbfe310", path2: "path25d86b9c4-016b-41bd-8b33-c93cc6d81991")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path132b1660f-2a6b-48bf-8665-f7c117d6f80b", path2: "path2e5bb4fb1-50e9-45ce-939e-82bd8d116f87")
…

@vbreuss vbreuss merged commit 9123628 into main Dec 16, 2024
15 checks passed
@vbreuss vbreuss deleted the topic/add-awexpect-to-compression-2 branch December 16, 2024 20:04
@github-actions
Copy link

github-actions bot commented Feb 1, 2025

This is addressed in release v4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor A change or improvement without functional impact state: released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants