Skip to content

fix: start implementing Path simulation #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2024
Merged

fix: start implementing Path simulation #564

merged 4 commits into from
Apr 16, 2024

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Apr 15, 2024 •
edited
Loading

Implements

  • AltDirectorySeparatorChar
  • DirectorySeparatorChar
  • PathSeparator
  • VolumeSeparatorChar
  • GetInvalidFileNameChars()
  • GetInvalidPathChars()
  • GetPathRoot(string)
  • GetTempPath()

See #460

@vbreuss
Implement
649b77f 
- AltDirectorySeparatorChar
- DirectorySeparatorChar
- PathSeparator
- VolumeSeparatorChar
- GetInvalidFileNameChars()
- GetInvalidPathChars()
@vbreuss vbreuss added the enhancement New feature or request label Apr 15, 2024
@vbreuss vbreuss self-assigned this Apr 15, 2024
@vbreuss vbreuss enabled auto-merge (squash) April 15, 2024 18:22
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 15, 2024
View reviewed changes
Source/Testably.Abstractions.Testing/Helpers/Execute.SimulatedPath.cs
"Insecure temporary file creation methods should not be used. Use `Path.Combine(Path.GetTempPath(), Path.GetRandomFileName())` instead.")]
#endif
public string GetTempFileName()
=> System.IO.Path.GetTempFileName();

Check failure

Code scanning / SonarCloud

Insecure temporary file creation methods should not be used

<!--SONAR_ISSUE_KEY:AY7i_2mZjG1B-jWivcrH-->'Path.GetTempFileName()' is insecure. Use 'Path.GetRandomFileName()' instead. <p>See more on <a href="https://sonarcloud.io/project/issues?id=Testably_Testably.Abstractions&issues=AY7i_2mZjG1B-jWivcrH&open=AY7i_2mZjG1B-jWivcrH&pullRequest=564">SonarCloud</a></p>
@github-actions
Copy link

github-actions bot commented Apr 15, 2024

Stryker.NET mutation tested the changes in the pull request:
Mutation testing badge

@vbreuss vbreuss force-pushed the topic/start-implementing-path-simulation branch from c2b29b7 to 86f9622 Compare April 16, 2024 05:44
@vbreuss vbreuss force-pushed the topic/start-implementing-path-simulation branch from 86f9622 to 2625b02 Compare April 16, 2024 05:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
11.6% Duplication on New Code

See analysis details on SonarCloud

@vbreuss vbreuss merged commit fbb10c1 into main Apr 16, 2024
@vbreuss vbreuss deleted the topic/start-implementing-path-simulation branch April 16, 2024 14:20
@vbreuss vbreuss mentioned this pull request Apr 16, 2024
Merged
@github-actions
Copy link

github-actions bot commented May 5, 2024

This is addressed in release v3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vbreuss vbreuss

Labels

enhancement New feature or request state: released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbreuss