Skip to content

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Apr 7, 2024

Refactor some implementation details, to catch uncaught errors (see Stryker.NET):

  • Allow null in IStorage.GetOrAddDrive to simplify the implementation
  • Add tests for Notification.ExecuteWhileWaiting
  • Extract getting the name for an AssemblyName to an extension method to allow testing it
  • Avoid including the default value for int in the choices in the random tests
  • Extract getting a shared IRandom instance from the IFileSystem to an extension method to allow testing it
  • Fix the test for changing a disposed timer in .NET 8 or greater (it returns false instead of throwing an ObjectDisposedException)

@github-actions
Copy link

github-actions bot commented Apr 7, 2024

Stryker.NET mutation tested the changes in the pull request:
Mutation testing badge

@vbreuss vbreuss self-assigned this Apr 7, 2024
@vbreuss vbreuss added the refactor A change or improvement without functional impact label Apr 7, 2024
@vbreuss vbreuss marked this pull request as ready for review April 7, 2024 10:15
@vbreuss vbreuss enabled auto-merge (squash) April 7, 2024 10:16
@vbreuss vbreuss changed the title refactor: improve test coverage refactor: improve mutation score Apr 7, 2024
@vbreuss vbreuss disabled auto-merge April 7, 2024 10:17
@vbreuss vbreuss enabled auto-merge (squash) April 7, 2024 10:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vbreuss vbreuss merged commit c8d5d18 into main Apr 7, 2024
@vbreuss vbreuss deleted the topic/improve-test-coverage branch April 7, 2024 10:30
@github-actions
Copy link

github-actions bot commented Apr 7, 2024

This is addressed in release v3.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor A change or improvement without functional impact state: released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants