Skip to content

fix: sonar issue xUnit1040 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2024
Merged

fix: sonar issue xUnit1040 #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3e46a7
Fix "xUnit1040" The type argument to TheoryData is nullable, while th…
vbreuss Jan 7, 2024
1deab76
Merge branch 'main' into topic/fix-nullability-in-theorydata
vbreuss Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ public void

#region Helpers

public static TheoryData<Expression<Action<IDirectoryInfo>>, string?, bool> GetDirectoryInfoCallbacks(string? path)
public static TheoryData<Expression<Action<IDirectoryInfo>>, string, bool> GetDirectoryInfoCallbacks(string? path)
{
TheoryData<Expression<Action<IDirectoryInfo>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IDirectoryInfo>>, string, bool> theoryData = new();
foreach (var item in GetDirectoryInfoCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand All @@ -130,7 +130,7 @@ public void
return theoryData;
}

private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
Expression<Action<IDirectoryInfo>> Callback)>
GetDirectoryInfoCallbackTestParameters(string value)
{
Expand Down
6 changes: 3 additions & 3 deletions Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ public void

#region Helpers

public static TheoryData<Expression<Action<IDirectoryInfoFactory>>, string?, bool> GetDirectoryInfoFactoryCallbacks(string? path)
public static TheoryData<Expression<Action<IDirectoryInfoFactory>>, string, bool> GetDirectoryInfoFactoryCallbacks(string? path)
{
TheoryData<Expression<Action<IDirectoryInfoFactory>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IDirectoryInfoFactory>>, string, bool> theoryData = new();
foreach (var item in GetDirectoryInfoFactoryCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand All @@ -108,7 +108,7 @@ public void
return theoryData;
}

private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
Expression<Action<IDirectoryInfoFactory>> Callback)>
GetDirectoryInfoFactoryCallbackTestParameters(string value)
{
Expand Down
4 changes: 2 additions & 2 deletions Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(

#region Helpers

public static TheoryData<Expression<Action<IDriveInfoFactory>>, string?, bool> GetDriveInfoFactoryCallbacks(string? path)
public static TheoryData<Expression<Action<IDriveInfoFactory>>, string, bool> GetDriveInfoFactoryCallbacks(string? path)
{
TheoryData<Expression<Action<IDriveInfoFactory>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IDriveInfoFactory>>, string, bool> theoryData = new();
foreach (var item in GetDriveInfoFactoryCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand Down
6 changes: 3 additions & 3 deletions Tests/Testably.Abstractions.Tests/FileSystem/File/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ public void

#region Helpers

public static TheoryData<Expression<Action<IFile>>, string?, bool> GetFileCallbacks(string? path)
public static TheoryData<Expression<Action<IFile>>, string, bool> GetFileCallbacks(string? path)
{
TheoryData<Expression<Action<IFile>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IFile>>, string, bool> theoryData = new();
foreach (var item in GetFileCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand All @@ -120,7 +120,7 @@ public void
return theoryData;
}

private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
Expression<Action<IFile>> Callback)>
GetFileCallbackTestParameters(string value)
{
Expand Down
6 changes: 3 additions & 3 deletions Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ public void

#region Helpers

public static TheoryData<Expression<Action<IFileInfo>>, string?, bool> GetFileInfoCallbacks(string? path)
public static TheoryData<Expression<Action<IFileInfo>>, string, bool> GetFileInfoCallbacks(string? path)
{
TheoryData<Expression<Action<IFileInfo>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IFileInfo>>, string, bool> theoryData = new();
foreach (var item in GetFileInfoCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand All @@ -98,7 +98,7 @@ public void
return theoryData;
}

private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
Expression<Action<IFileInfo>> Callback)>
GetFileInfoCallbackTestParameters(string value)
{
Expand Down
6 changes: 3 additions & 3 deletions Tests/Testably.Abstractions.Tests/FileSystem/FileInfoFactory/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ public void

#region Helpers

public static TheoryData<Expression<Action<IFileInfoFactory>>, string?, bool> GetFileInfoFactoryCallbacks(string? path)
public static TheoryData<Expression<Action<IFileInfoFactory>>, string, bool> GetFileInfoFactoryCallbacks(string? path)
{
TheoryData<Expression<Action<IFileInfoFactory>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IFileInfoFactory>>, string, bool> theoryData = new();
foreach (var item in GetFileInfoFactoryCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand All @@ -108,7 +108,7 @@ public void
return theoryData;
}

private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
Expression<Action<IFileInfoFactory>> Callback)>
GetFileInfoFactoryCallbackTestParameters(string value)
{
Expand Down
6 changes: 3 additions & 3 deletions Tests/Testably.Abstractions.Tests/FileSystem/FileStreamFactory/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ public void

#region Helpers

public static TheoryData<Expression<Action<IFileStreamFactory>>, string?, bool> GetFileStreamFactoryCallbacks(string? path)
public static TheoryData<Expression<Action<IFileStreamFactory>>, string, bool> GetFileStreamFactoryCallbacks(string? path)
{
TheoryData<Expression<Action<IFileStreamFactory>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IFileStreamFactory>>, string, bool> theoryData = new();
foreach (var item in GetFileStreamFactoryCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand All @@ -121,7 +121,7 @@ public void
return theoryData;
}

private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
Expression<Action<IFileStreamFactory>> Callback)>
GetFileStreamFactoryCallbackTestParameters(string value)
{
Expand Down
6 changes: 3 additions & 3 deletions Tests/Testably.Abstractions.Tests/FileSystem/FileSystemInfo/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(

#region Helpers

public static TheoryData<Expression<Action<IFileSystemInfo>>, string?, bool> GetFileSystemInfoCallbacks(string? path)
public static TheoryData<Expression<Action<IFileSystemInfo>>, string, bool> GetFileSystemInfoCallbacks(string? path)
{
TheoryData<Expression<Action<IFileSystemInfo>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IFileSystemInfo>>, string, bool> theoryData = new();
foreach (var item in GetFileSystemInfoCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand All @@ -61,7 +61,7 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(
return theoryData;
}

private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
Expression<Action<IFileSystemInfo>> Callback)>
GetFileSystemInfoCallbackTestParameters(string value)
{
Expand Down
6 changes: 3 additions & 3 deletions Tests/Testably.Abstractions.Tests/FileSystem/FileSystemWatcherFactory/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ public void

#region Helpers

public static TheoryData<Expression<Action<IFileSystemWatcherFactory>>, string?, bool> GetFileSystemWatcherFactoryCallbacks(string? path)
public static TheoryData<Expression<Action<IFileSystemWatcherFactory>>, string, bool> GetFileSystemWatcherFactoryCallbacks(string? path)
{
TheoryData<Expression<Action<IFileSystemWatcherFactory>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IFileSystemWatcherFactory>>, string, bool> theoryData = new();
foreach (var item in GetFileSystemWatcherFactoryCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand All @@ -111,7 +111,7 @@ public void
return theoryData;
}

private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
Expression<Action<IFileSystemWatcherFactory>> Callback)>
GetFileSystemWatcherFactoryCallbackTestParameters(string value)
{
Expand Down
6 changes: 3 additions & 3 deletions Tests/Testably.Abstractions.Tests/FileSystem/Path/ExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(

#region Helpers

public static TheoryData<Expression<Action<IPath>>, string?, bool> GetPathCallbacks(string? path)
public static TheoryData<Expression<Action<IPath>>, string, bool> GetPathCallbacks(string? path)
{
TheoryData<Expression<Action<IPath>>, string?, bool> theoryData = new();
TheoryData<Expression<Action<IPath>>, string, bool> theoryData = new();
foreach (var item in GetPathCallbackTestParameters(path!)
.Where(item => item.TestType.HasFlag(path.ToTestType())))
{
Expand All @@ -80,7 +80,7 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(
return theoryData;
}

private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
Expression<Action<IPath>> Callback)>
GetPathCallbackTestParameters(string value)
{
Expand Down