refactor: avoid Thread.Sleep in Tests
#374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
referenced
this pull request
in Testably/Testably.Abstractions.FluentAssertions
Aug 23, 2023
…4.0 (#38) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Testably.Abstractions.Interface](https://github.com/Testably/Testably.Abstractions) | nuget | minor | `2.3.4` -> `2.4.0` | --- ### Release Notes <details> <summary>Testably/Testably.Abstractions (Testably.Abstractions.Interface)</summary> ### [`v2.4.0`](https://github.com/Testably/Testably.Abstractions/releases/tag/v2.4.0) #### What's Changed - chore(deps): update dependency testably.abstractions.testing to v2.3.4 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/346](https://github.com/Testably/Testably.Abstractions/pull/346) - chore(deps): update dependency microsoft.net.test.sdk to v17.7.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/347](https://github.com/Testably/Testably.Abstractions/pull/347) - refactor: analyze brittle tests by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/348](https://github.com/Testably/Testably.Abstractions/pull/348) - refactor: use retry action for failed tests by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/349](https://github.com/Testably/Testably.Abstractions/pull/349) - chore(deps): update dependency moq to v4.20.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/351](https://github.com/Testably/Testably.Abstractions/pull/351) - chore(deps): update dependency moq to v4.20.1 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/352](https://github.com/Testably/Testably.Abstractions/pull/352) - chore(deps): update dependency moq to v4.20.2 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/353](https://github.com/Testably/Testably.Abstractions/pull/353) - fix: sonar deprecation warning by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/355](https://github.com/Testably/Testably.Abstractions/pull/355) - chore(deps): update dependency moq to v4.20.69 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/358](https://github.com/Testably/Testably.Abstractions/pull/358) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.24 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/359](https://github.com/Testably/Testably.Abstractions/pull/359) - chore(deps): update dependency microsoft.net.test.sdk to v17.7.1 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/360](https://github.com/Testably/Testably.Abstractions/pull/360) - chore(deps): update dependency microsoft.codeanalysis.csharp to v4.7.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/361](https://github.com/Testably/Testably.Abstractions/pull/361) - refactor: remove dependency on Moq by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/362](https://github.com/Testably/Testably.Abstractions/pull/362) - feat: add renovate package group for Testably.Abstractions packages by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/363](https://github.com/Testably/Testably.Abstractions/pull/363) - feat: improve release pipeline to automatically create a Github release by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/364](https://github.com/Testably/Testably.Abstractions/pull/364) - refactor: use FluentAssertion extensions methods by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/365](https://github.com/Testably/Testably.Abstractions/pull/365) - refactor: update FluentAssertions extensions by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/367](https://github.com/Testably/Testably.Abstractions/pull/367) - refactor: improve test coverage by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/368](https://github.com/Testably/Testably.Abstractions/pull/368) - chore(deps): update dependency testableio.system.io.abstractions to v19.2.61 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/369](https://github.com/Testably/Testably.Abstractions/pull/369) - chore(deps): update dependency testableio.system.io.abstractions to v19.2.64 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/370](https://github.com/Testably/Testably.Abstractions/pull/370) - feat: add mergify configuration file by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/371](https://github.com/Testably/Testably.Abstractions/pull/371) - refactor: improve test coverage by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/372](https://github.com/Testably/Testably.Abstractions/pull/372) - fix: sonar issue due to `CA1826` by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/373](https://github.com/Testably/Testably.Abstractions/pull/373) - refactor: avoid `Thread.Sleep` in Tests by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/374](https://github.com/Testably/Testably.Abstractions/pull/374) - refactor: improve test coverage by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/375](https://github.com/Testably/Testably.Abstractions/pull/375) - fix: `FileSystemInitializer` supports nested directories by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/376](https://github.com/Testably/Testably.Abstractions/pull/376) **Full Changelog**: Testably/Testably.Abstractions@v2.3.4...v2.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions.FluentAssertions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mergify bot
referenced
this pull request
in Testably/Testably.Abstractions.FluentAssertions
Aug 23, 2023
#40) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Testably.Abstractions.Testing](https://github.com/Testably/Testably.Abstractions) | nuget | minor | `2.3.4` -> `2.4.1` | --- ### Release Notes <details> <summary>Testably/Testably.Abstractions (Testably.Abstractions.Testing)</summary> ### [`v2.4.1`](https://github.com/Testably/Testably.Abstractions/releases/tag/v2.4.1) #### What's Changed - chore(deps): update testably.abstractions packages to v2.4.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/366](https://github.com/Testably/Testably.Abstractions/pull/366) - chore(deps): update dependency fluentassertions to v6.12.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/377](https://github.com/Testably/Testably.Abstractions/pull/377) - fix: error in release pipeline by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/378](https://github.com/Testably/Testably.Abstractions/pull/378) **Full Changelog**: Testably/Testably.Abstractions@v2.4.0...v2.4.1 ### [`v2.4.0`](https://github.com/Testably/Testably.Abstractions/releases/tag/v2.4.0) #### What's Changed - chore(deps): update dependency testably.abstractions.testing to v2.3.4 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/346](https://github.com/Testably/Testably.Abstractions/pull/346) - chore(deps): update dependency microsoft.net.test.sdk to v17.7.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/347](https://github.com/Testably/Testably.Abstractions/pull/347) - refactor: analyze brittle tests by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/348](https://github.com/Testably/Testably.Abstractions/pull/348) - refactor: use retry action for failed tests by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/349](https://github.com/Testably/Testably.Abstractions/pull/349) - chore(deps): update dependency moq to v4.20.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/351](https://github.com/Testably/Testably.Abstractions/pull/351) - chore(deps): update dependency moq to v4.20.1 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/352](https://github.com/Testably/Testably.Abstractions/pull/352) - chore(deps): update dependency moq to v4.20.2 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/353](https://github.com/Testably/Testably.Abstractions/pull/353) - fix: sonar deprecation warning by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/355](https://github.com/Testably/Testably.Abstractions/pull/355) - chore(deps): update dependency moq to v4.20.69 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/358](https://github.com/Testably/Testably.Abstractions/pull/358) - chore(deps): update danielpalme/reportgenerator-github-action action to v5.1.24 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/359](https://github.com/Testably/Testably.Abstractions/pull/359) - chore(deps): update dependency microsoft.net.test.sdk to v17.7.1 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/360](https://github.com/Testably/Testably.Abstractions/pull/360) - chore(deps): update dependency microsoft.codeanalysis.csharp to v4.7.0 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/361](https://github.com/Testably/Testably.Abstractions/pull/361) - refactor: remove dependency on Moq by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/362](https://github.com/Testably/Testably.Abstractions/pull/362) - feat: add renovate package group for Testably.Abstractions packages by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/363](https://github.com/Testably/Testably.Abstractions/pull/363) - feat: improve release pipeline to automatically create a Github release by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/364](https://github.com/Testably/Testably.Abstractions/pull/364) - refactor: use FluentAssertion extensions methods by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/365](https://github.com/Testably/Testably.Abstractions/pull/365) - refactor: update FluentAssertions extensions by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/367](https://github.com/Testably/Testably.Abstractions/pull/367) - refactor: improve test coverage by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/368](https://github.com/Testably/Testably.Abstractions/pull/368) - chore(deps): update dependency testableio.system.io.abstractions to v19.2.61 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/369](https://github.com/Testably/Testably.Abstractions/pull/369) - chore(deps): update dependency testableio.system.io.abstractions to v19.2.64 by [@​renovate](https://github.com/renovate) in [https://github.com/Testably/Testably.Abstractions/pull/370](https://github.com/Testably/Testably.Abstractions/pull/370) - feat: add mergify configuration file by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/371](https://github.com/Testably/Testably.Abstractions/pull/371) - refactor: improve test coverage by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/372](https://github.com/Testably/Testably.Abstractions/pull/372) - fix: sonar issue due to `CA1826` by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/373](https://github.com/Testably/Testably.Abstractions/pull/373) - refactor: avoid `Thread.Sleep` in Tests by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/374](https://github.com/Testably/Testably.Abstractions/pull/374) - refactor: improve test coverage by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/375](https://github.com/Testably/Testably.Abstractions/pull/375) - fix: `FileSystemInitializer` supports nested directories by [@​vbreuss](https://github.com/vbreuss) in [https://github.com/Testably/Testably.Abstractions/pull/376](https://github.com/Testably/Testably.Abstractions/pull/376) **Full Changelog**: Testably/Testably.Abstractions@v2.3.4...v2.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions.FluentAssertions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://renovatebot.com){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes S2925 Do not use 'Thread.Sleep()' in a test
Using
Thread.Sleepin a test might introduce unpredictable and inconsistent results depending on the environment. Furthermore, it will block the thread, which means the system resources are not being fully used.Fix S6444 Not specifying a timeout for regular expressions is security-sensitive
Not specifying a timeout for regular expressions can lead to a Denial-of-Service attack. Pass a timeout when using
System.Text.RegularExpressionsto process untrusted input because a malicious user might craft a value for which the evaluation lasts excessively long.by applying a timeout of 1 second to the path transformation regex.