Skip to content

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Jul 23, 2023

Fix implementation for Path.GetRelativePath to use transform relative paths relative to the current directory of the mocked file system (see TestableIO/System.IO.Abstractions#773).

@vbreuss vbreuss added the bug Something isn't working label Jul 23, 2023
@vbreuss vbreuss self-assigned this Jul 23, 2023
@vbreuss vbreuss marked this pull request as ready for review July 24, 2023 05:30
@vbreuss vbreuss merged commit a7e455a into main Jul 24, 2023
@vbreuss vbreuss deleted the topic/vb/fix-implementation-of-path-getrelativepath branch July 24, 2023 05:30
vbreuss referenced this pull request Jul 24, 2023
#339)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[Testably.Abstractions.Testing](https://github.com/Testably/Testably.Abstractions)
| nuget | patch | `2.3.2` -> `2.3.3` |

---

### Release Notes

<details>
<summary>Testably/Testably.Abstractions
(Testably.Abstractions.Testing)</summary>

###
[`v2.3.3`](https://github.com/Testably/Testably.Abstractions/releases/tag/v2.3.3)

#### What's Changed

- chore(deps): update dependency testably.abstractions to v2.3.2 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/327](https://github.com/Testably/Testably.Abstractions/pull/327)
- chore(deps): update dependency testably.abstractions.testing to v2.3.2
by [@&#8203;renovate](https://github.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/330](https://github.com/Testably/Testably.Abstractions/pull/330)
- feat: add `ToString` methods to simplify debugging by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/335](https://github.com/Testably/Testably.Abstractions/pull/335)
- fix: parameter validation in `Path.GetFullPath` by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/334](https://github.com/Testably/Testably.Abstractions/pull/334)
- fix: implementation of `Path.GetRelativePath` by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/336](https://github.com/Testably/Testably.Abstractions/pull/336)
- fix: set stryker version to v3.7.1 on release builds by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/337](https://github.com/Testably/Testably.Abstractions/pull/337)

**Full Changelog**:
v2.3.2...v2.3.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vbreuss referenced this pull request Jul 24, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[Testably.Abstractions](https://github.com/Testably/Testably.Abstractions)
| nuget | patch | `2.3.2` -> `2.3.3` |

---

### Release Notes

<details>
<summary>Testably/Testably.Abstractions
(Testably.Abstractions)</summary>

###
[`v2.3.3`](https://github.com/Testably/Testably.Abstractions/releases/tag/v2.3.3)

#### What's Changed

- chore(deps): update dependency testably.abstractions to v2.3.2 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/327](https://github.com/Testably/Testably.Abstractions/pull/327)
- chore(deps): update dependency testably.abstractions.testing to v2.3.2
by [@&#8203;renovate](https://github.com/renovate) in
[https://github.com/Testably/Testably.Abstractions/pull/330](https://github.com/Testably/Testably.Abstractions/pull/330)
- feat: add `ToString` methods to simplify debugging by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/335](https://github.com/Testably/Testably.Abstractions/pull/335)
- fix: parameter validation in `Path.GetFullPath` by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/334](https://github.com/Testably/Testably.Abstractions/pull/334)
- fix: implementation of `Path.GetRelativePath` by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/336](https://github.com/Testably/Testably.Abstractions/pull/336)
- fix: set stryker version to v3.7.1 on release builds by
[@&#8203;vbreuss](https://github.com/vbreuss) in
[https://github.com/Testably/Testably.Abstractions/pull/337](https://github.com/Testably/Testably.Abstractions/pull/337)

**Full Changelog**:
v2.3.2...v2.3.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants