Skip to content

coverage: add tests for InMemoryStorage #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2023
Merged

coverage: add tests for InMemoryStorage #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb0b9a3
Check NullOrEmpty on GetDrive
vbtig Apr 10, 2023
bed8819
Ensure rollback execution is tested
vbtig Apr 10, 2023
71b467f
Fix GetDrives with whitespace and simplify `ResolveLinkTarget`
vbtig Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Testably.Abstractions.Testing/Helpers/PathHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ internal static bool HasIllegalCharacters(this string path, IFileSystem fileSyst
() => false);
}

internal static bool IsUncPath(this string? path)
internal static bool IsUncPath([NotNullWhen(true)]this string? path)
{
if (path == null)
{
Expand Down
5 changes: 2 additions & 3 deletions Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,15 +433,14 @@ public IStorageContainer GetOrCreateContainer(
out IStorageContainer? initialContainer) &&
initialContainer.LinkTarget != null)
{
IStorageLocation nextLocation =
IStorageLocation? nextLocation =
_fileSystem.Storage.GetLocation(initialContainer.LinkTarget);
if (_containers.TryGetValue(nextLocation,
out IStorageContainer? container))
{
if (returnFinalTarget)
{
nextLocation = ResolveFinalLinkTarget(container, location) ??
nextLocation;
nextLocation = ResolveFinalLinkTarget(container, location);
}

return nextLocation;
Expand Down
118 changes: 65 additions & 53 deletions Tests/Testably.Abstractions.Testing.Tests/Storage/InMemoryStorageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,57 +45,6 @@ public void Copy_Overwrite_ShouldAdjustAvailableFreeSpace(
.Be(availableFreeSpaceBefore + file2Size - file1Size);
}

[Theory]
[AutoData]
public void Replace_WithoutBackup_ShouldNotChangeAvailableFreeSpace(
int file1Size, int file2Size)
{
MockFileSystem fileSystem = new();
IDriveInfo mainDrive = fileSystem.DriveInfo.New("".PrefixRoot());
IRandom random = RandomFactory.Shared;
byte[] file1Content = new byte[file1Size];
byte[] file2Content = new byte[file2Size];
random.NextBytes(file1Content);
random.NextBytes(file2Content);

fileSystem.File.WriteAllBytes("foo", file1Content);
fileSystem.File.WriteAllBytes("bar", file2Content);
long availableFreeSpaceBefore = mainDrive.AvailableFreeSpace;

fileSystem.File.Replace("foo", "bar", "backup");

long availableFreeSpaceAfter = mainDrive.AvailableFreeSpace;
availableFreeSpaceAfter.Should()
.Be(availableFreeSpaceBefore);
}

[Theory]
[AutoData]
public void Replace_WithBackup_ShouldChangeAvailableFreeSpace(
int file1Size, int file2Size, int file3Size)
{
MockFileSystem fileSystem = new();
IDriveInfo mainDrive = fileSystem.DriveInfo.New("".PrefixRoot());
IRandom random = RandomFactory.Shared;
byte[] file1Content = new byte[file1Size];
byte[] file2Content = new byte[file2Size];
byte[] file3Content = new byte[file3Size];
random.NextBytes(file1Content);
random.NextBytes(file2Content);
random.NextBytes(file3Content);

fileSystem.File.WriteAllBytes("foo", file1Content);
fileSystem.File.WriteAllBytes("bar", file2Content);
fileSystem.File.WriteAllBytes("backup", file3Content);
long availableFreeSpaceBefore = mainDrive.AvailableFreeSpace;

fileSystem.File.Replace("foo", "bar", "backup", true);

long availableFreeSpaceAfter = mainDrive.AvailableFreeSpace;
availableFreeSpaceAfter.Should()
.Be(availableFreeSpaceBefore + file2Size);
}

[Fact]
public void CurrentDirectory_ShouldBeInitializedToDefaultRoot()
{
Expand Down Expand Up @@ -126,6 +75,18 @@ public void Delete_RaceCondition_ShouldReturnFalse()
exception.Should().BeOfType<DirectoryNotFoundException>();
}

[Theory]
[InlineData((string?)null)]
[InlineData("")]
[InlineData(" ")]
[InlineData("\t")]
public void GetDrive_NullOrWhitespace_ShouldReturnNull(string? driveName)
{
IStorageDrive? result = Storage.GetDrive(driveName);

result.Should().BeNull();
}

[Theory]
[AutoData]
public void Move_RequestDeniedForChild_ShouldRollback(
Expand All @@ -134,9 +95,9 @@ public void Move_RequestDeniedForChild_ShouldRollback(
IStorageLocation location = Storage.GetLocation(locationPath);
IStorageLocation destination = Storage.GetLocation(destinationPath);
IStorageLocation child1Location =
Storage.GetLocation(Path.Combine(locationPath, "foo"));
Storage.GetLocation(Path.Combine(locationPath, "foo1"));
IStorageLocation child2Location =
Storage.GetLocation(Path.Combine(locationPath, "bar"));
Storage.GetLocation(Path.Combine(locationPath, "foo2"));
LockableContainer lockedContainer = new(FileSystem);
Storage.TryAddContainer(
location,
Expand Down Expand Up @@ -164,6 +125,57 @@ public void Move_RequestDeniedForChild_ShouldRollback(
exception.Should().BeOfType<IOException>();
}

[Theory]
[AutoData]
public void Replace_WithBackup_ShouldChangeAvailableFreeSpace(
int file1Size, int file2Size, int file3Size)
{
MockFileSystem fileSystem = new();
IDriveInfo mainDrive = fileSystem.DriveInfo.New("".PrefixRoot());
IRandom random = RandomFactory.Shared;
byte[] file1Content = new byte[file1Size];
byte[] file2Content = new byte[file2Size];
byte[] file3Content = new byte[file3Size];
random.NextBytes(file1Content);
random.NextBytes(file2Content);
random.NextBytes(file3Content);

fileSystem.File.WriteAllBytes("foo", file1Content);
fileSystem.File.WriteAllBytes("bar", file2Content);
fileSystem.File.WriteAllBytes("backup", file3Content);
long availableFreeSpaceBefore = mainDrive.AvailableFreeSpace;

fileSystem.File.Replace("foo", "bar", "backup", true);

long availableFreeSpaceAfter = mainDrive.AvailableFreeSpace;
availableFreeSpaceAfter.Should()
.Be(availableFreeSpaceBefore + file2Size);
}

[Theory]
[AutoData]
public void Replace_WithoutBackup_ShouldNotChangeAvailableFreeSpace(
int file1Size, int file2Size)
{
MockFileSystem fileSystem = new();
IDriveInfo mainDrive = fileSystem.DriveInfo.New("".PrefixRoot());
IRandom random = RandomFactory.Shared;
byte[] file1Content = new byte[file1Size];
byte[] file2Content = new byte[file2Size];
random.NextBytes(file1Content);
random.NextBytes(file2Content);

fileSystem.File.WriteAllBytes("foo", file1Content);
fileSystem.File.WriteAllBytes("bar", file2Content);
long availableFreeSpaceBefore = mainDrive.AvailableFreeSpace;

fileSystem.File.Replace("foo", "bar", "backup");

long availableFreeSpaceAfter = mainDrive.AvailableFreeSpace;
availableFreeSpaceAfter.Should()
.Be(availableFreeSpaceBefore);
}

[Theory]
[AutoData]
public void TryAddContainer_ShouldNotifyWhenAdded(string path)
Expand Down