Skip to content

fix: sonar issues #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: sonar issues #277

merged 1 commit into from
Mar 6, 2023

Conversation

@vbreuss
Copy link
Member

@vbreuss vbreuss commented Mar 6, 2023 •
edited
Loading

Fix two sonar issues in FileSystemInitializerExtensions.cs:

  • Use span-based 'string.Concat' and 'AsSpan' instead of 'Substring'
  • Use 'string.Contains' instead of 'string.IndexOf' to improve readability

Both issues are deactivated via #pragma directives, as the issues don't work under netstandard2.0.

@vbreuss vbreuss added the bug Something isn't working label Mar 6, 2023
@vbreuss vbreuss self-assigned this Mar 6, 2023
@vbreuss vbreuss enabled auto-merge (squash) March 6, 2023 09:23
@vbreuss vbreuss merged commit f316be3 into main Mar 6, 2023
@vbreuss vbreuss deleted the topic/vb/fix-sonar-issues branch March 6, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vbreuss vbreuss

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vbreuss @vbtig