fix: reject attribute and timestamp setters on read-only SafeFileHandle on Windows - #1102
Merged
Merged
Conversation
…dle` on Windows Windows needs `FILE_WRITE_ATTRIBUTES` for `SetFileInformationByHandle`, so the real file system throws `UnauthorizedAccessException` for a handle opened without `FileAccess.Write` while the mock silently applied the change.
Test Results 62 files ± 0 62 suites ±0 1h 18m 50s ⏱️ + 2m 50s Results for commit 1cf8a68. ± Comparison against base commit 015a573. This pull request removes 60096 and adds 60187 tests. Note that renamed tests count towards both.This pull request removes 6743 skipped tests and adds 6803 skipped tests. Note that renamed tests count towards both. |
|
|
This is addressed in release v7.1.0. |
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows needs
FILE_WRITE_ATTRIBUTESforSetFileInformationByHandle, so the real file system throwsUnauthorizedAccessExceptionfor a handle opened withoutFileAccess.Writewhile the mock silently applied the change.