fix: stop FileStream.New(handle) from re-applying the handle's FileMode - #1098
Merged
Merged
Conversation
…eMode` A stream created from a handle wraps the already open file, so replaying `CreateNew`, `Create`/`Truncate` or `Append` threw or wiped content written through the handle.
vbreuss
marked this pull request as draft
September 25, 2026 21:11
Test Results 62 files ± 0 62 suites ±0 1h 20m 8s ⏱️ + 4m 8s Results for commit 07cdd8a. ± Comparison against base commit 015a573. This pull request removes 60105 and adds 60278 tests. Note that renamed tests count towards both.This pull request removes 6743 skipped tests and adds 6743 skipped tests. Note that renamed tests count towards both. |
vbreuss
marked this pull request as ready for review
September 27, 2026 05:02
vbreuss
enabled auto-merge (squash)
September 27, 2026 05:02
vbreuss
disabled auto-merge
September 27, 2026 05:02
|
|
This is addressed in release v7.1.0. |
This was referenced Sep 28, 2026
Closed
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stream created from a handle wraps the already open file, so replaying
CreateNew,Create/TruncateorAppendthrew or wiped content written through the handle.