Skip to content

feat!: omit constructor parameters overloads for interfaces and types with only parameterless constructors #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 1 commit into from
Apr 22, 2026
Merged

feat!: omit constructor parameters overloads for interfaces and types with only parameterless constructors #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Source/Mockolate.SourceGenerators/Sources/Sources.MockClass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ internal static partial class Sources
public static string MockClass(string name, Class @class, bool hasOverloadResolutionPriority = false)
{
EquatableArray<Method>? constructors = (@class as MockClass)?.Constructors;
bool hasParameterizedConstructor = !@class.IsInterface &&
constructors?.Any(m => m.Parameters.Count > 0) == true;
string escapedClassName = @class.ClassFullName.EscapeForXmlDoc();
bool hasEvents = @class.AllEvents().Any(x => !x.IsStatic);
bool hasStaticEvents = @class.IsInterface &&
Expand Down Expand Up @@ -162,7 +164,7 @@ public static string MockClass(string name, Class @class, bool hasOverloadResolu
sb.Append("\t\t\t=> CreateMock(mockBehavior, setup, (object?[]?)null);").AppendLine();
sb.AppendLine();

if (!@class.IsInterface)
if (hasParameterizedConstructor)
{
sb.AppendXmlSummary(
$"Creates a new mock of <see cref=\"{escapedClassName}\" /> using the given <paramref name=\"constructorParameters\" /> to invoke the base-class constructor.");
Expand Down Expand Up @@ -206,7 +208,7 @@ public static string MockClass(string name, Class @class, bool hasOverloadResolu
sb.AppendXmlParam("setup", "Callback that receives the mock's setup surface and registers initial setups before the mock is returned, or <see langword=\"null\" /> to skip.");
sb.AppendXmlParam("constructorParameters", "Values forwarded to a matching base-class constructor, or <see langword=\"null\" /> to use the parameterless constructor.");
sb.AppendXmlReturns(createMockReturns);
sb.Append("\t\t").Append(@class.IsInterface ? "private" : "public").Append(" static ")
sb.Append("\t\t").Append(hasParameterizedConstructor ? "public" : "private").Append(" static ")
.Append(@class.ClassFullName)
.Append(" CreateMock(global::Mockolate.MockBehavior? mockBehavior, global::System.Action<")
.Append(setupType).Append(">? setup, object?[]? constructorParameters)").AppendLine();
Expand Down
58 changes: 58 additions & 0 deletions Tests/Mockolate.SourceGenerators.Tests/MockTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,64 @@ public MyBaseClass(global::Mockolate.MockRegistry mockRegistry, int value, bool
""").IgnoringNewlineStyle();
}

[Fact]
public async Task ForTypesWithOnlyParameterlessConstructor_ShouldOmitConstructorParametersOverloads()
{
GeneratorResult result = Generator
.Run("""
using Mockolate;

namespace MyCode;

public class Program
{
public static void Main(string[] args)
{
_ = MyBaseClass.CreateMock();
}
}

public class MyBaseClass
{
public MyBaseClass() { }
}
""");

await That(result.Sources).ContainsKey("Mock.MyBaseClass.g.cs").WhoseValue
.DoesNotContain("CreateMock(object?[] constructorParameters)").And
.DoesNotContain("CreateMock(global::Mockolate.MockBehavior mockBehavior, object?[] constructorParameters)").And
.DoesNotContain("object?[] constructorParameters)").And
.Contains("private static global::MyCode.MyBaseClass CreateMock(global::Mockolate.MockBehavior? mockBehavior, global::System.Action<global::Mockolate.Mock.IMockSetupForMyBaseClass>? setup, object?[]? constructorParameters)");
}
Comment thread
vbreuss marked this conversation as resolved.

[Fact]
public async Task ForTypesWithoutExplicitConstructor_ShouldOmitConstructorParametersOverloads()
{
GeneratorResult result = Generator
.Run("""
using Mockolate;

namespace MyCode;

public class Program
{
public static void Main(string[] args)
{
_ = MyBaseClass.CreateMock();
}
}

public class MyBaseClass
{
}
""");

await That(result.Sources).ContainsKey("Mock.MyBaseClass.g.cs").WhoseValue
.DoesNotContain("CreateMock(object?[] constructorParameters)").And
.DoesNotContain("object?[] constructorParameters)").And
.Contains("private static global::MyCode.MyBaseClass CreateMock(global::Mockolate.MockBehavior? mockBehavior, global::System.Action<global::Mockolate.Mock.IMockSetupForMyBaseClass>? setup, object?[]? constructorParameters)");
}

[Fact]
public async Task ForTypesWithoutPublicOrProtectedConstructor_ShouldOnlyGenerateMockThatThrowsException()
{
Expand Down
Loading