Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSVC debugger visualization file #20

Merged
merged 4 commits into from
Sep 15, 2018
Merged

Conversation

cmakshin
Copy link
Contributor

@cmakshin cmakshin commented Aug 14, 2018

This pull request contains a file which can be used by the Visual Studio debugger for "pretty-printing" tsl::ordered_* containers.

@Tessil
Copy link
Owner

Tessil commented Aug 15, 2018

Hello,

Thank you for your contribution.

I'm currently in holiday without my laptop for the next few weeks, so I can't really test it. I'll check to merge it on my return so that I can check and test it a bit more beforehand as I'm not familiar with the natvis files.

@cmakshin
Copy link
Contributor Author

cmakshin commented Aug 15, 2018 via email

@Tessil
Copy link
Owner

Tessil commented Sep 15, 2018

Hello,

I made some minor changes to your branch. If it seems OK to you, I will merge the branch to the master.

@cmakshin
Copy link
Contributor Author

cmakshin commented Sep 15, 2018 via email

@Tessil
Copy link
Owner

Tessil commented Sep 15, 2018

I also hesitate to remove the IncludeView="detailed" in bucket_count and max_load_factor. Is there a reason to not leave them in the default view?

@cmakshin
Copy link
Contributor Author

That's the behavior of the std::unordered_map visualizer shipped with MSVC and I tried to be as close to it as possible.

@Tessil Tessil merged commit 3f06209 into Tessil:master Sep 15, 2018
@Tessil
Copy link
Owner

Tessil commented Sep 15, 2018

Ok, makes sense. I merged the changes.

I'll check to merge the 'natvis' files in the other tsl projects when I have time.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants