Refactor progressbar #369
Merged
Refactor progressbar #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pe5h4 can you review pls? This MR comes with changes to public/body.css in all applications http://gitlab.teskalabs.int/seacat/seacat-webui/-/merge_requests/139 I will make these changes in other applications progress-v.mp4 |
Pe5h4
reviewed
Oct 5, 2022
src/containers/SplashScreen.js
Outdated
| style={{maxWidth: "38%"}} | ||
| /> : <h1>Loading ...</h1>} | ||
| <div className="progress mt-3" style={{maxWidth: "38%", margin: "20px auto 0 auto"}}> | ||
| style={{width: "38%", position: "absolute", bottom: '60%', left: '50%', transform: 'translate(-50%, 0)'}} |
There was a problem hiding this comment.
@Aringoaway Is it possible to add those style to splashscreen.scss (or some other general stylesheet e.g. styles/index.scss) ? Or does it have to be styled directly in the component due to pending of the scss files on application initialization?
Pe5h4
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of Spinner add SplashScreen