Refactor/input buttons update #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pe5h4
requested changes
Oct 3, 2022
added 2 commits
October 3, 2022 17:43
…skaLabs/asab-webui into refactor/input-buttons-update
Pe5h4
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
@petrKavulok Pls check the comment I wrote about the color before merging
| box-shadow: none; | ||
| } | ||
| &:active{ | ||
| box-shadow: inset 0 0 0 .2rem rgba(0,123,255,.25); |
There was a problem hiding this comment.
@petrKavulok Are you sure about that rgba color? Why dont you use our $primary color ?
There was a problem hiding this comment.
Also, will your solution work properly in dark mode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR