Make monaco loader part of the application #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration for loader
Pe5h4
approved these changes
Apr 6, 2022
ateska
approved these changes
Apr 6, 2022
|
Will this have an impact on the core application size? |
|
@ateska Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES:
@monaco-editor/reactlibrary was replaced withreact-monaco-editormonaco-editor-webpack-pluginwas addedentriesand babel preset configuration were extended in order to enable editor workerscorejs@3exact version was installed and specified (before was dependecy of other packages) in order to prevent versioning missmatch for babel