Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic closing of the sidebar on sidebar item click for small screens #228

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Automatic closing of the sidebar on sidebar item click for small screens #228

merged 4 commits into from
Jan 26, 2022

Conversation

titkov49
Copy link
Contributor

@titkov49 titkov49 commented Jan 25, 2022 •
edited
Loading

Other changes:

  • Fix bug when stop-propagation-container wasn't removed on big screens
  • Fix bug when some elements (like ace-editor in LibraryContainer) had higher z-index then stop-propagation-container

@titkov49 titkov49 changed the title Sidebar close on item click Automatic closing of the sidebar on sidebar item click for small screens Jan 25, 2022
@titkov49 titkov49 requested review from Pe5h4 and ateska January 25, 2022 13:26
@titkov49
Copy link
Contributor Author

Screen.Recording.2022-01-25.at.14.23.22.mov

@titkov49
Copy link
Contributor Author

@ateska @Pe5h4 review please :)

@titkov49 titkov49 merged commit 4a95510 into master Jan 26, 2022
@titkov49 titkov49 deleted the feature/sidebar-close-on-item-click branch January 26, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ateska ateska ateska approved these changes

@Pe5h4 Pe5h4 Pe5h4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@titkov49 @ateska @Pe5h4